Skip to content

test: including official opencypher tck #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvca merged 9 commits into from
Feb 6, 2026

fix: more opencypher issues from tck tests

6993ad5
Select commit
Loading
Failed to load commit list.
Merged

test: including official opencypher tck #3358

fix: more opencypher issues from tck tests
6993ad5
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Feb 6, 2026 in 0s

15 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 15
           

Complexity increasing per file
==============================
- engine/src/main/java/com/arcadedb/query/opencypher/executor/steps/OrderByStep.java  4
- engine/src/main/java/com/arcadedb/query/opencypher/ast/LogicalExpression.java  19
- engine/src/main/java/com/arcadedb/query/opencypher/executor/ExpressionEvaluator.java  33
- engine/src/main/java/com/arcadedb/query/opencypher/ast/OrderByClause.java  2
- engine/src/main/java/com/arcadedb/query/opencypher/executor/CypherFunctionFactory.java  11
- engine/src/main/java/com/arcadedb/query/opencypher/executor/steps/CreateStep.java  2
- engine/src/main/java/com/arcadedb/query/opencypher/executor/CypherExecutionPlan.java  8
- engine/src/main/java/com/arcadedb/query/opencypher/ast/BooleanExpression.java  1
- engine/src/main/java/com/arcadedb/query/opencypher/ast/InExpression.java  8
- engine/src/main/java/com/arcadedb/query/opencypher/executor/steps/WithStep.java  2
- engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherExpressionBuilder.java  13
- engine/src/main/java/com/arcadedb/query/opencypher/ast/TernaryLogicalExpression.java  3
- engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKResultMatcher.java  113
- engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java  20
- engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKReportPlugin.java  18
- engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKValueParser.java  98
- engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKStepDefinitions.java  64
- engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherSemanticValidator.java  270
         

Complexity decreasing per file
==============================
+ engine/src/main/java/com/arcadedb/query/opencypher/ast/ComparisonExpression.java  -1

See the complete overview on Codacy

Annotations

Check notice on line 221 in engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherSemanticValidator.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherSemanticValidator.java#L221 

Avoid unused private methods such as 'validateVariableScope(CypherStatement)'.

Check warning on line 513 in engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherSemanticValidator.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherSemanticValidator.java#L513 

Avoid unused method parameters such as 'operand'.

Check warning on line 699 in engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherSemanticValidator.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherSemanticValidator.java#L699 

Avoid unused method parameters such as 'deleteClause'.

Check notice on line 732 in engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherSemanticValidator.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/main/java/com/arcadedb/query/opencypher/parser/CypherSemanticValidator.java#L732 

Avoid unnecessary if..then..else statements when returning booleans

Check warning on line 54 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKReportPlugin.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKReportPlugin.java#L54 

Avoid unused method parameters such as 'event'.

Check warning on line 83 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKReportPlugin.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKReportPlugin.java#L83 

Avoid unused method parameters such as 'event'.

Check notice on line 264 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKResultMatcher.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKResultMatcher.java#L264 

Avoid unnecessary if..then..else statements when returning booleans

Check warning on line 43 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java#L43 

Avoid unused private fields such as 'labelCount'.

Check warning on line 43 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java#L43 

Perhaps 'labelCount' could be replaced by a local variable.

Check warning on line 62 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java#L62 

Avoid unused local variables such as 'currentLabels'.

Check warning on line 63 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java#L63 

Avoid unused local variables such as 'currentProps'.

Check warning on line 97 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKSideEffectChecker.java#L97 

Avoid unused local variables such as 'addedLabels'.

Check warning on line 65 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKStepDefinitions.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKStepDefinitions.java#L65 

Perhaps 'scenarioName' could be replaced by a local variable.

Check warning on line 139 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKStepDefinitions.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKStepDefinitions.java#L139 

Avoid throwing raw exception types.

Check warning on line 104 in engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKValueParser.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

engine/src/test/java/com/arcadedb/query/opencypher/tck/TCKValueParser.java#L104 

Avoid unused method parameters such as 'trimmed'.
View more details on Codacy Production