Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,12 @@ void simpleCypherQuery() {
assertThat(CollectionUtils.countEntries(result)).isEqualTo(10);
}, false, 10);
}

@Test
void simpleOpenCypherQuery() {
database.transaction(() -> {
final ResultSet result = database.query("opencypher", "MATCH(p:Beer) RETURN * LIMIT 10");
assertThat(CollectionUtils.countEntries(result)).isEqualTo(10);
}, false, 10);
Comment on lines +70 to +75
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The simpleOpenCypherQuery method is nearly identical to simpleCypherQuery, with the primary difference being the query language used. This introduces code duplication. Consider refactoring these similar test cases into a single parameterized test or a common helper method to enhance maintainability and reduce redundancy. This approach would make it easier to manage and extend query language tests in the future.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The simpleOpenCypherQuery method is nearly identical to simpleCypherQuery, with the primary difference being the query language used. This introduces code duplication. Consider refactoring these similar test cases into a single parameterized test or a common helper method to enhance maintainability and reduce redundancy. This approach would make it easier to manage and extend query language tests in the future.

@robfrank

}
}
Loading