-
-
Notifications
You must be signed in to change notification settings - Fork 116
feat: Enhance RemoteServer and Console create-user to assign group
#1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2f01559
fix: add pwd command to console help
gramian 1541614
Overload createUser method
gramian 23ae1af
Enhance create user command to assign group
gramian 9528b7c
Add minimal passing usermgmt console test
gramian 942f850
Merge branch 'ArcadeData:main' into main
gramian affb1ba
Use Map type instead of HashMap
gramian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,7 +74,7 @@ public String toString() { | |
| return protocol + "://" + currentServer + ":" + currentPort; | ||
| } | ||
|
|
||
| public void createUser(final String userName, final String password, final List<String> databases) { | ||
| public void createUser(final String userName, final String password, final HashMap<String,String> databases) { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. again, prefer interface: |
||
| try { | ||
| final HttpURLConnection connection = createConnection("POST", getUrl("server")); | ||
|
|
||
|
|
@@ -83,8 +83,8 @@ public void createUser(final String userName, final String password, final List< | |
| jsonUser.put("password", password); | ||
| if (databases != null && !databases.isEmpty()) { | ||
| final JSONObject databasesJson = new JSONObject(); | ||
| for (final String dbName : databases) | ||
| databasesJson.put(dbName, new String[] { "admin" }); | ||
| for (Map.Entry<String, String> entry : databases.entrySet()) | ||
| databasesJson.put(entry.getKey(), new String[] { entry.getValue() }); | ||
| jsonUser.put("databases", databasesJson); | ||
| } | ||
|
|
||
|
|
@@ -101,6 +101,16 @@ public void createUser(final String userName, final String password, final List< | |
| } | ||
| } | ||
|
|
||
| public void createUser(final String userName, final String password, final List<String> databases) { | ||
|
|
||
| HashMap<String,String> databasesWithGroups = new HashMap<String, String>(); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. again: |
||
|
|
||
| for (final String dbName : databases) | ||
| databasesWithGroups.put(dbName, "admin"); | ||
|
|
||
| createUser(userName, password, databasesWithGroups); | ||
| } | ||
|
|
||
| public void dropUser(final String userName) { | ||
| try { | ||
| final HttpURLConnection connection = createConnection("POST", getUrl("server")); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my suggestion:
final Map<String,String>...