Skip to content

Add test for two empty strings in binary comparator #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Nov 5, 2023
Merged

Add test for two empty strings in binary comparator #1298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c8014f
Add test for two empty strings in binary comparator
gramian Nov 2, 2023
738d5c6
Use isEmpty instead of equals
gramian Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions engine/src/main/java/com/arcadedb/serializer/BinaryComparator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,9 @@ public static boolean equalsString(final String buffer1, final String buffer2) {
if (buffer1 == null || buffer2 == null)
return false;

if (buffer1.isEmpty() && buffer2.isEmpty())
return true;

return equalsBytes(buffer1.getBytes(DatabaseFactory.getDefaultCharset()),
buffer2.getBytes(DatabaseFactory.getDefaultCharset()));
}
Expand Down