Skip to content

Conversation

@gramian
Copy link
Collaborator

@gramian gramian commented Jul 9, 2023

What does this PR do?

This PR fixes the problem of missing distance functions. This is achieved by making the the registered names of distance functions in the factory lower case except the first letter.

Additional Notes

I removed the Sparse Vector Inner Product function(s) since they seem to be based on internal unsupported type (SparseVector) which AFAIK is not used in ArcadeDB

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca self-assigned this Jul 10, 2023
@lvca
Copy link
Contributor

lvca commented Jul 10, 2023

From your idea I've pushed this fix: b696e13. It registers the name in lower case and transforms in lower case the name when it's retrieved.

@lvca lvca closed this Jul 10, 2023
@lvca lvca self-requested a review July 10, 2023 06:35
@lvca lvca added this to the 23.7.1 milestone Jul 10, 2023
lvca added a commit that referenced this pull request Jul 10, 2023
…to be based on internal unsupported type (SparseVector) which is not used in ArcadeDB

From #1160
@lvca
Copy link
Contributor

lvca commented Jul 10, 2023

Just realized you also removed the sparse vector, copying your fix: 0b1cd2f

mergify bot added a commit that referenced this pull request Feb 3, 2025
Bumps `jline.version` from 3.28.0 to 3.29.0.
Updates `org.jline:jline-terminal` from 3.28.0 to 3.29.0
Release notes

*Sourced from [org.jline:jline-terminal's releases](https://github.com/jline/jline3/releases).*

> 3.29.0
> ------
> 
> 💥 Breaking changes
> -----------------------
> 
> * Undeprecate ConsolePrompt methods et al ([#1148](https://github.com/jline/jline3/pull/1148)) [`@​quintesse`](https://github.com/quintesse)
> 
> 🚀 New features and improvements
> -------------------------------
> 
> * Add text-only prompt element for console-ui ([#1138](https://github.com/jline/jline3/pull/1138)) [`@​quintesse`](https://github.com/quintesse)
> * Dynamic console-ui prompt improvements, see [#1051](https://github.com/jline/jline3/issues/1051) ([#1132](https://github.com/jline/jline3/pull/1132)) [`@​quintesse`](https://github.com/quintesse)
> 
> 🐛 Bug Fixes
> -----------
> 
> * AnsiConsole should always obey the terminal (fixes [#1160](https://github.com/jline/jline3/issues/1160)) ([#1161](https://github.com/jline/jline3/pull/1161)) [`@​cstamas`](https://github.com/cstamas)
> * Add overloaded no-arg compile method ([#1137](https://github.com/jline/jline3/pull/1137)) [`@​iflan`](https://github.com/iflan)
> * Move catch to proper place ([#1133](https://github.com/jline/jline3/pull/1133)) [`@​cstamas`](https://github.com/cstamas)
> 
> 📦 Dependency updates
> --------------------
> 
> * Bump groovy.version from 4.0.24 to 4.0.25 ([#1163](https://github.com/jline/jline3/pull/1163)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.graalvm.sdk:graal-sdk from 24.1.1 to 24.1.2 ([#1159](https://github.com/jline/jline3/pull/1159)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.1 to 2.44.2 ([#1155](https://github.com/jline/jline3/pull/1155)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.sonatype.central:central-publishing-maven-plugin from 0.6.0 to 0.7.0 ([#1149](https://github.com/jline/jline3/pull/1149)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump com.diffplug.spotless:spotless-maven-plugin from 2.43.0 to 2.44.1 ([#1147](https://github.com/jline/jline3/pull/1147)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.0.1 to 4.1.1 ([#1146](https://github.com/jline/jline3/pull/1146)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.apache.ivy:ivy from 2.5.2 to 2.5.3 ([#1144](https://github.com/jline/jline3/pull/1144)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump net.java.dev.jna:jna from 5.15.0 to 5.16.0 ([#1142](https://github.com/jline/jline3/pull/1142)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump junit.version from 5.11.3 to 5.11.4 ([#1135](https://github.com/jline/jline3/pull/1135)) @[dependabot[bot]](https://github.com/apps/dependabot)
> 
> 👻 Maintenance
> -------------
> 
> * Replace `Path.toFile()` ([#1158](https://github.com/jline/jline3/pull/1158)) [`@​snazy`](https://github.com/snazy)


Commits

* [`c095db8`](jline/jline3@c095db8) [maven-release-plugin] prepare release jline-3.29.0
* [`a6a7786`](jline/jline3@a6a7786) Undeprecate ConsolePrompt methods ([#1148](https://github.com/jline/jline3/issues/1148))
* [`ee5ac1b`](jline/jline3@ee5ac1b) Bump groovy.version from 4.0.24 to 4.0.25 ([#1163](https://github.com/jline/jline3/issues/1163))
* [`57030d4`](jline/jline3@57030d4) Replace `Path.toFile()` ([#1158](https://github.com/jline/jline3/issues/1158))
* [`f869217`](jline/jline3@f869217) AnsiConsole should always obey the terminal (fixes [#1160](https://github.com/jline/jline3/issues/1160)) ([#1161](https://github.com/jline/jline3/issues/1161))
* [`c7f7fbe`](jline/jline3@c7f7fbe) Bump org.graalvm.sdk:graal-sdk from 24.1.1 to 24.1.2 ([#1159](https://github.com/jline/jline3/issues/1159))
* [`ddfb352`](jline/jline3@ddfb352) Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.1 to 2.44.2 ([#1155](https://github.com/jline/jline3/issues/1155))
* [`4504b46`](jline/jline3@4504b46) Bump org.sonatype.central:central-publishing-maven-plugin ([#1149](https://github.com/jline/jline3/issues/1149))
* [`5e6aa3e`](jline/jline3@5e6aa3e) Bump com.diffplug.spotless:spotless-maven-plugin from 2.43.0 to 2.44.1 ([#1147](https://github.com/jline/jline3/issues/1147))
* [`1e70700`](jline/jline3@1e70700) Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.0.1 to 4.1.1 ([#1146](https://github.com/jline/jline3/issues/1146))
* Additional commits viewable in [compare view](jline/jline3@jline-3.28.0...jline-3.29.0)

  

Updates `org.jline:jline-reader` from 3.28.0 to 3.29.0
Release notes

*Sourced from [org.jline:jline-reader's releases](https://github.com/jline/jline3/releases).*

> 3.29.0
> ------
> 
> 💥 Breaking changes
> -----------------------
> 
> * Undeprecate ConsolePrompt methods et al ([#1148](https://github.com/jline/jline3/pull/1148)) [`@​quintesse`](https://github.com/quintesse)
> 
> 🚀 New features and improvements
> -------------------------------
> 
> * Add text-only prompt element for console-ui ([#1138](https://github.com/jline/jline3/pull/1138)) [`@​quintesse`](https://github.com/quintesse)
> * Dynamic console-ui prompt improvements, see [#1051](https://github.com/jline/jline3/issues/1051) ([#1132](https://github.com/jline/jline3/pull/1132)) [`@​quintesse`](https://github.com/quintesse)
> 
> 🐛 Bug Fixes
> -----------
> 
> * AnsiConsole should always obey the terminal (fixes [#1160](https://github.com/jline/jline3/issues/1160)) ([#1161](https://github.com/jline/jline3/pull/1161)) [`@​cstamas`](https://github.com/cstamas)
> * Add overloaded no-arg compile method ([#1137](https://github.com/jline/jline3/pull/1137)) [`@​iflan`](https://github.com/iflan)
> * Move catch to proper place ([#1133](https://github.com/jline/jline3/pull/1133)) [`@​cstamas`](https://github.com/cstamas)
> 
> 📦 Dependency updates
> --------------------
> 
> * Bump groovy.version from 4.0.24 to 4.0.25 ([#1163](https://github.com/jline/jline3/pull/1163)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.graalvm.sdk:graal-sdk from 24.1.1 to 24.1.2 ([#1159](https://github.com/jline/jline3/pull/1159)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.1 to 2.44.2 ([#1155](https://github.com/jline/jline3/pull/1155)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.sonatype.central:central-publishing-maven-plugin from 0.6.0 to 0.7.0 ([#1149](https://github.com/jline/jline3/pull/1149)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump com.diffplug.spotless:spotless-maven-plugin from 2.43.0 to 2.44.1 ([#1147](https://github.com/jline/jline3/pull/1147)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.0.1 to 4.1.1 ([#1146](https://github.com/jline/jline3/pull/1146)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.apache.ivy:ivy from 2.5.2 to 2.5.3 ([#1144](https://github.com/jline/jline3/pull/1144)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump net.java.dev.jna:jna from 5.15.0 to 5.16.0 ([#1142](https://github.com/jline/jline3/pull/1142)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump junit.version from 5.11.3 to 5.11.4 ([#1135](https://github.com/jline/jline3/pull/1135)) @[dependabot[bot]](https://github.com/apps/dependabot)
> 
> 👻 Maintenance
> -------------
> 
> * Replace `Path.toFile()` ([#1158](https://github.com/jline/jline3/pull/1158)) [`@​snazy`](https://github.com/snazy)


Commits

* [`c095db8`](jline/jline3@c095db8) [maven-release-plugin] prepare release jline-3.29.0
* [`a6a7786`](jline/jline3@a6a7786) Undeprecate ConsolePrompt methods ([#1148](https://github.com/jline/jline3/issues/1148))
* [`ee5ac1b`](jline/jline3@ee5ac1b) Bump groovy.version from 4.0.24 to 4.0.25 ([#1163](https://github.com/jline/jline3/issues/1163))
* [`57030d4`](jline/jline3@57030d4) Replace `Path.toFile()` ([#1158](https://github.com/jline/jline3/issues/1158))
* [`f869217`](jline/jline3@f869217) AnsiConsole should always obey the terminal (fixes [#1160](https://github.com/jline/jline3/issues/1160)) ([#1161](https://github.com/jline/jline3/issues/1161))
* [`c7f7fbe`](jline/jline3@c7f7fbe) Bump org.graalvm.sdk:graal-sdk from 24.1.1 to 24.1.2 ([#1159](https://github.com/jline/jline3/issues/1159))
* [`ddfb352`](jline/jline3@ddfb352) Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.1 to 2.44.2 ([#1155](https://github.com/jline/jline3/issues/1155))
* [`4504b46`](jline/jline3@4504b46) Bump org.sonatype.central:central-publishing-maven-plugin ([#1149](https://github.com/jline/jline3/issues/1149))
* [`5e6aa3e`](jline/jline3@5e6aa3e) Bump com.diffplug.spotless:spotless-maven-plugin from 2.43.0 to 2.44.1 ([#1147](https://github.com/jline/jline3/issues/1147))
* [`1e70700`](jline/jline3@1e70700) Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.0.1 to 4.1.1 ([#1146](https://github.com/jline/jline3/issues/1146))
* Additional commits viewable in [compare view](jline/jline3@jline-3.28.0...jline-3.29.0)

  

Updates `org.jline:jline-terminal-jni` from 3.28.0 to 3.29.0
Release notes

*Sourced from [org.jline:jline-terminal-jni's releases](https://github.com/jline/jline3/releases).*

> 3.29.0
> ------
> 
> 💥 Breaking changes
> -----------------------
> 
> * Undeprecate ConsolePrompt methods et al ([#1148](https://github.com/jline/jline3/pull/1148)) [`@​quintesse`](https://github.com/quintesse)
> 
> 🚀 New features and improvements
> -------------------------------
> 
> * Add text-only prompt element for console-ui ([#1138](https://github.com/jline/jline3/pull/1138)) [`@​quintesse`](https://github.com/quintesse)
> * Dynamic console-ui prompt improvements, see [#1051](https://github.com/jline/jline3/issues/1051) ([#1132](https://github.com/jline/jline3/pull/1132)) [`@​quintesse`](https://github.com/quintesse)
> 
> 🐛 Bug Fixes
> -----------
> 
> * AnsiConsole should always obey the terminal (fixes [#1160](https://github.com/jline/jline3/issues/1160)) ([#1161](https://github.com/jline/jline3/pull/1161)) [`@​cstamas`](https://github.com/cstamas)
> * Add overloaded no-arg compile method ([#1137](https://github.com/jline/jline3/pull/1137)) [`@​iflan`](https://github.com/iflan)
> * Move catch to proper place ([#1133](https://github.com/jline/jline3/pull/1133)) [`@​cstamas`](https://github.com/cstamas)
> 
> 📦 Dependency updates
> --------------------
> 
> * Bump groovy.version from 4.0.24 to 4.0.25 ([#1163](https://github.com/jline/jline3/pull/1163)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.graalvm.sdk:graal-sdk from 24.1.1 to 24.1.2 ([#1159](https://github.com/jline/jline3/pull/1159)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.1 to 2.44.2 ([#1155](https://github.com/jline/jline3/pull/1155)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.sonatype.central:central-publishing-maven-plugin from 0.6.0 to 0.7.0 ([#1149](https://github.com/jline/jline3/pull/1149)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump com.diffplug.spotless:spotless-maven-plugin from 2.43.0 to 2.44.1 ([#1147](https://github.com/jline/jline3/pull/1147)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.0.1 to 4.1.1 ([#1146](https://github.com/jline/jline3/pull/1146)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.apache.ivy:ivy from 2.5.2 to 2.5.3 ([#1144](https://github.com/jline/jline3/pull/1144)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump net.java.dev.jna:jna from 5.15.0 to 5.16.0 ([#1142](https://github.com/jline/jline3/pull/1142)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump junit.version from 5.11.3 to 5.11.4 ([#1135](https://github.com/jline/jline3/pull/1135)) @[dependabot[bot]](https://github.com/apps/dependabot)
> 
> 👻 Maintenance
> -------------
> 
> * Replace `Path.toFile()` ([#1158](https://github.com/jline/jline3/pull/1158)) [`@​snazy`](https://github.com/snazy)


Commits

* [`c095db8`](jline/jline3@c095db8) [maven-release-plugin] prepare release jline-3.29.0
* [`a6a7786`](jline/jline3@a6a7786) Undeprecate ConsolePrompt methods ([#1148](https://github.com/jline/jline3/issues/1148))
* [`ee5ac1b`](jline/jline3@ee5ac1b) Bump groovy.version from 4.0.24 to 4.0.25 ([#1163](https://github.com/jline/jline3/issues/1163))
* [`57030d4`](jline/jline3@57030d4) Replace `Path.toFile()` ([#1158](https://github.com/jline/jline3/issues/1158))
* [`f869217`](jline/jline3@f869217) AnsiConsole should always obey the terminal (fixes [#1160](https://github.com/jline/jline3/issues/1160)) ([#1161](https://github.com/jline/jline3/issues/1161))
* [`c7f7fbe`](jline/jline3@c7f7fbe) Bump org.graalvm.sdk:graal-sdk from 24.1.1 to 24.1.2 ([#1159](https://github.com/jline/jline3/issues/1159))
* [`ddfb352`](jline/jline3@ddfb352) Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.1 to 2.44.2 ([#1155](https://github.com/jline/jline3/issues/1155))
* [`4504b46`](jline/jline3@4504b46) Bump org.sonatype.central:central-publishing-maven-plugin ([#1149](https://github.com/jline/jline3/issues/1149))
* [`5e6aa3e`](jline/jline3@5e6aa3e) Bump com.diffplug.spotless:spotless-maven-plugin from 2.43.0 to 2.44.1 ([#1147](https://github.com/jline/jline3/issues/1147))
* [`1e70700`](jline/jline3@1e70700) Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.0.1 to 4.1.1 ([#1146](https://github.com/jline/jline3/issues/1146))
* Additional commits viewable in [compare view](jline/jline3@jline-3.28.0...jline-3.29.0)

  

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants