Support building for Amiga with CMake #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccawley2011
force-pushed
the
amiga-cmake
branch
from
ea8e41f to
71f4082
Compare
chris-y
reviewed
Jan 12, 2025
| @@ -121,14 +121,16 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| amiga: | |||
| # - { name: "AmigaOS 3", host: "m68k-amigaos", system: "amigaos3" } | |||
| - { name: "AmigaOS 4", host: "ppc-amigaos", system: "amiga" } | |||
| # - { name: "AmigaOS 3", host: "m68k-amigaos", cmake-flags: -DM68K_CRT=nix20 } | |||
There was a problem hiding this comment.
Where is this M68K_CRT define used? (and the PPC one on the line below)
There was a problem hiding this comment.
They're used in the toolchain files that are bundled with the docker images.
| - name: Build | ||
| run: make SYSTEM=${{ matrix.amiga.system }} CROSS=${{ matrix.amiga.host }}- | ||
| run: cmake --build build/ --config ${{env.BUILD_TYPE}} --parallel |
There was a problem hiding this comment.
What is env.BUILD_TYPE? The cmake uses SYSTEM I think?
There was a problem hiding this comment.
It's set to Release at the top of the workflow file, and it determines which debug and optimisation levels are used.
ccawley2011
force-pushed
the
amiga-cmake
branch
from
71f4082 to
a5e9c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.