Fix names in Data binder generators. Fixes issue #230

ArcBees · Dec 18, 2013 · 0e9a003 · 0e9a003
1 parent 9a9f2b0
commit 0e9a003
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsonBuilderGenerator.java b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/JsonBuilderGenerator.java
@@ -95,7 +95,7 @@ public String generate(TreeLogger treeLogger,
         String name = nameAnnotation != null
           ? nameAnnotation.value()
           : methName.replaceFirst("^(get|set)", "");
-        if (nameAnnotation != null) {
+        if (nameAnnotation == null) {
           name = name.substring(0, 1).toLowerCase() + name.substring(1);
         }
         attrs.add(name);

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/rebind/XmlBuilderGenerator.java b/gwtquery-core/src/main/java/com/google/gwt/query/rebind/XmlBuilderGenerator.java
@@ -85,7 +85,7 @@ public void generateMethod(SourceWriter sw, JMethod method, TreeLogger logger)
     String name = nameAnnotation != null ? nameAnnotation.value()
         : method.getName().replaceFirst("^(get|set)", "");
 
-    if (nameAnnotation != null) {
+    if (nameAnnotation == null) {
       name = name.substring(0, 1).toLowerCase() + name.substring(1);
     }
 

diff --git a/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryAjaxTestGwt.java b/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryAjaxTestGwt.java
@@ -72,6 +72,8 @@ interface Item extends JsonBuilder {
   interface JsonExample extends JsonBuilder {
     int getA();
     JsonExample getB();
+    @Name("M")
+    int getM();
     @Name("u")
     String getUrl();
     long getD();
@@ -87,14 +89,14 @@ interface JsonExample extends JsonBuilder {
     Function getF();
     void setF(Function f);
   }
-
-
+
   boolean functionRun = false;
   public void testJsonBuilder() {
-    String json = "{a:1, b:{a:2,b:{a:3}},u:url, d:'2','t':['hola','adios'], 'z': true}";
+    String json = "{M:0, a:1, b:{a:2,b:{a:3}},u:url, d:'2','t':['hola','adios'], 'z': true}";
     JsonExample c = GWT.create(JsonExample.class);
     assertEquals(0, c.getA());
     c.parse(json, true);
+    assertEquals(0, c.getM());
     assertEquals(1, c.getA());
     assertNotNull(c.getB());
     assertEquals(2, c.getB().getA());
@@ -129,12 +131,10 @@ public void f() {
     c.setItems(Arrays.asList(items));
     assertEquals(2000l, c.getItems().get(0).getDate().getTime());
     assertEquals(3000l, c.getItems().get(1).getDate().getTime());
-    String s = "{'a':1,'b':{'a':2,'b':{'a':3}},'u':'url','d':1234,'t':['foo','bar'],'z':false,'y':'y','items':[{'date':2000},{'date':3000}]}";
+    String s = "{'M':0,'a':1,'b':{'a':2,'b':{'a':3}},'u':'url','d':1234,'t':['foo','bar'],'z':false,'y':'y','items':[{'date':2000},{'date':3000}]
     assertEquals(s, c.toString().replaceAll("\"", "'"));
-
-
   }
-
+  
   interface XmlExample extends XmlBuilder {
     interface T extends XmlBuilder {
     }