-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BaseChosenValueListBox.java #242
Conversation
isAccepted method of BaseChosenValueListBox check against value #241
Could you provide a test that would fail before your change (and pass after)? Thanks for your contribution! |
Sorry I spent more than one hour to try find right combination of a Chrome and chrome driver :( The mvn gwt:run -Pintegration-test does not work too (Failed to execute goal org.codehaus.mojo:gwt-maven-plugin:2.7.0:run (default-cli) on project integration-test: The parameters 'runTarget' for goal org.codehaus.mojo:gwt-maven-plugin:2.7.0:run are missing or invalid) I think you can ease reproduce the error if update the listBox in SimpleValueListBox with custom key provider. listBox = new ChosenValueListBox<CarBrand>(getRenderer(), new ProvidesKey<CarBrand>() {
@Override
public Object getKey(final CarBrand item) {
return item.name();
}
}, options); |
I commit proposed update. Something wrong with check stile report generation.... |
Rollback the test |
LGTM, thanks for the contribution! |
@@ -0,0 +1,84 @@ | |||
/** | |||
* Copyright 2014 ArcBees Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2015
return listBox; | ||
} | ||
|
||
protected Renderer<CarBrand> getRenderer() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this method, simply use RENDERER
where needed
Fix the review notes
Fix Checkstyle
Update BaseChosenValueListBox.java
isAccepted method of BaseChosenValueListBox check against value #241