gwtchosen-142 Tab index is not reset if change handler triggers further ...

[cplaetzinger]

Possible fix for #142

[christiangoudreau]

Possible? Did you assert that it fixes the problem?

Could you write a test?

[cplaetzinger]

It works for me and fixes the issue I have described in #142. I wrote "possible" because I have not much experience working with GWT and CSS. So it would be fine if you or @jDramaix will review the patch.

If will try to find some time to write a test.

[jDramaix]

I disagree with this change and it seems to be a change specific for your need. Tab index should be set back only when the component loses the focus.

If I understand correctly, your issue comes from the fact that the ui is updated and the chosen component doesn't have the focus anymore and tab index is not set back to the original value (so it means that the component doesn't receive the blur event... ) ? How do you update your ui ?

[christiangoudreau]

@jDramaix

[jDramaix]

@christiangoudreau ?

[christiangoudreau]

What do we do with this? @jDramaix

[jDramaix]

I'm against this change and waiting more info from @cplaetzinger .

[cplaetzinger]

What we do can be summarized as follows:

• Listen for changes on the ChosenListBox by adding a ChangeHandler
• Once the handler gets triggered the event is forwarded to our own event handling
• At the end this leads to a communication with the server part of our GWT application. During event handling/server communication the application displays a spinning activity indicator (like spin.js) using an overlay window.
• The result received from the server is used to update the ui, e.g add components, remove components, change some attributes on existing components. But it does not build an entire new windows. Thus the original components still exists.

[olafleur]

Last commit was more than 6 months ago. Closing. Feel free to reopen a pull request as needed.