Custom ActionException subclasses are not rethrown as new ActionException #340
Conversation
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.fail; | ||
|
|
||
|
|
|
Nice Job |
|
Checkstyle is failing I think |
|
Fix build, otherwise looks good! |
|
I'll plan a patch release for the end of the week |
| throw new ActionException(e.getMessage()); | ||
| e.setStackTrace(new StackTraceElement[]{}); | ||
|
|
||
| throw e; |
There was a problem hiding this comment.
make sure that e is logged before throwing it to the client.
There was a problem hiding this comment.
Make sure causes (and their stack trace) are not propagated either.
There was a problem hiding this comment.
I think logging is already done by logger.log(Level.WARNING, newMessage, e); no?
|
In 895a5bd I removed the cause's stacktrace. What do yo think of this @Chris-V @christiangoudreau ? I don't think we can remove the cause completely, since |
| @@ -0,0 +1,25 @@ | |||
| /** | |||
| * Copyright 2011 ArcBees Inc. | |||
There was a problem hiding this comment.
nvermind, what Christian said prolly work better. :)
There was a problem hiding this comment.
I'll update all copyrights of all all files to 2013 in another PR
On Thu, Nov 14, 2013 at 10:33 AM, Brandon Donnelson <
[email protected]> wrote:
In
gwtp-core/gwtp-dispatch-server-guice/src/test/java/com/gwtplatform/dispatch/server/ActionExceptionThrownByValidator.java:@@ -0,0 +1,25 @@
+/**
- * Copyright 2011 ArcBees Inc.
copyright 2013
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/340/files#r7662155
.
Simon-Pierre Gingras | *Developer
M: 418.929.0230 *| T: @spgingras | *G+: SP Gingras
ArcBees http://www.arcbees.com/ *| Blog http://blog.arcbees.com/ |
Facebook http://facebook.com/QueenOfTheBees |
LinkedInhttp://www.linkedin.com/company/arcbees
There was a problem hiding this comment.
Would the open source copy right header, is that automatic?
|
Nice job. |
|
Would it be useful to add more javadoc? |
|
lgtm, good job |
|
@branflake2267 Do you see places where it would be useful? |
|
I would think Javadoc could be a bonus on any api classes the dev might want to touch. I'm of the opinion more is better with Javadoc. :) |
|
+1 to add information in the javadoc of the dispatcher that it erase the full stacktrace to avoid security holes. |
|
Added a little bit of documentation in f51282c . Not sure if enough or correct (I'm not a big javadoc writer :P) |
|
LGTM |
Custom ActionException subclasses are not rethrown as new ActionException
Custom ActionException subclasses are not rethrown as new ActionException
Custom ActionException subclasses are not rethrown as new ActionException Former-commit-id: 0fb839e
This is a tentative fix for #312
Notice that the actual fix is in
AbstractDispatchServiceImpl. All other classes in this patch are for testing purposes only.I remove all the stacktrace from the thrown exception using
e.setStackTrace(new StackTraceElement[]{});