Avoid that the RootPresenter.unlockScreen() throws a javascript exception #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od throw an javascript exception ElementNotFound
|
LGTM, what's the build problem? |
|
Failed on compile. I kicked it off again to see if was a fluke. |
|
LGTM :) |
|
Do you think I can merge ? |
|
Once the build is fixed, yes! :D |
|
Please fix the build problems and merge :D |
|
The build issue was an OutOfMemoryError during the gwt compilation of the carstore How can I trigger the build again ? |
|
There's a run button in teamcity :D I've added it to the queue |
|
ah good to know :D |
|
TeamCity seems to be down... |
jDramaix
added a commit
that referenced
this pull request
Aug 8, 2013
Avoid that the RootPresenter.unlockScreen() throws a javascript exception
jDramaix
added a commit
that referenced
this pull request
Apr 4, 2014
Avoid that the RootPresenter.unlockScreen() throws a javascript exception
hpehl
pushed a commit
to hpehl/GWTP
that referenced
this pull request
Dec 9, 2014
Avoid that the RootPresenter.unlockScreen() throws a javascript exception Former-commit-id: 43d9207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the screen is not previously locked, call of the unlockScreen method throws an javascript exception ElementNotFound