Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement on GWTP Crawler #290

Merged
merged 4 commits into from
Jul 17, 2013
Merged

Enhancement on GWTP Crawler #290

merged 4 commits into from
Jul 17, 2013

Conversation

imrabti
Copy link
Contributor

@imrabti imrabti commented Jul 15, 2013

  • Update HTMLUnit to latest version, change Browser to FIREFOX_17.
  • Some enhancement to CrawlServiceServlet, wait until the JavaScript engine finishes processing.

@imrabti
Update HTMLUnit to latest version, change Browser to FIREFOX_17.
0540a18 
Some enhancement to CrawlServiceServlet, wait until the JavaScript engine finishes processing.
branflake2267
branflake2267 reviewed Jul 15, 2013
View reviewed changes
...crawler-service/src/main/java/com/gwtplatform/crawlerservice/server/CrawlServiceServlet.java
@@ -64,16 +82,17 @@

@Inject
CrawlServiceServlet(final Provider<WebClient> webClientProvider,
final Logger log,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm final?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and align with (

@branflake2267
Copy link
Contributor

LGTM :)

@christiangoudreau
Copy link
Member

Build errors

@imrabti
Copy link
Contributor Author

imrabti commented Jul 16, 2013

The build error is related to some check-style problem in gwtp-dispatch-server-guice.

@imrabti
Copy link
Contributor Author

imrabti commented Jul 17, 2013

I have fixed all the CheckStyle errors, and launched mvn clean install, it was successful.
But I still see a build failure reported by TeamCity, its like it failed trying to compile gwt-carestore.

@jDramaix
Copy link
Contributor

There is an OutOfMemory Error when it tries to compile the carstore

[12:45:39][com.gwtplatform:gwtp-carstore] [INFO] Compiling 18 permutations
[12:45:41][com.gwtplatform:gwtp-carstore] [INFO] Compiling permutation 0...
[12:46:00][com.gwtplatform:gwtp-carstore] [INFO] Process output
[12:46:00][com.gwtplatform:gwtp-carstore] [INFO] Compiling
[12:46:00][com.gwtplatform:gwtp-carstore] [INFO] Compiling permutation 1...
[12:46:04][com.gwtplatform:gwtp-carstore] [INFO] Compiling permutation 2...
[12:46:37][com.gwtplatform:gwtp-carstore] [INFO] Compiling permutation 3...
[12:46:44][com.gwtplatform:gwtp-carstore] [INFO] [ERROR] OutOfMemoryError: Increase heap size or lower gwt.jjs.maxThreads
[12:46:45][com.gwtplatform:gwtp-carstore] [INFO] java.lang.OutOfMemoryError

18 permutations !! Woooaw :)

@branflake2267
Copy link
Contributor

Just a note, last release I had to up maven heap size so I could build it and I used export MAVEN_OPTS='-Xmx512m -XX:MaxPermSize=128m'.

@christiangoudreau
Copy link
Member

LGTM

imrabti added a commit that referenced this pull request Jul 17, 2013
@imrabti
Merge pull request #290 from ArcBees/mi_crawlerEnhance
306000f 
Enhancement on GWTP Crawler
@imrabti imrabti merged commit 306000f into master Jul 17, 2013
@imrabti imrabti deleted the mi_crawlerEnhance branch July 17, 2013 16:00
imrabti added a commit that referenced this pull request Apr 4, 2014
@imrabti
Merge pull request #290 from ArcBees/mi_crawlerEnhance
87ffb25 
Enhancement on GWTP Crawler
hpehl pushed a commit to hpehl/GWTP that referenced this pull request Dec 9, 2014
@imrabti
Merge pull request ArcBees#290 from ArcBees/mi_crawlerEnhance
7a2a152 
Enhancement on GWTP Crawler


Former-commit-id: 87ffb25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imrabti @branflake2267 @christiangoudreau @jDramaix