RootPresenter.RootView : add and use the protected method getAppRootPane...

[clavelm]

Add and use the protected method RootPresenter.RootView#getAppRootPanel()

That method can be overriden to change what RootPanel to use and easily embed an app in an existing webpage.

Example of attaching the app to a panel with id="appPanel" :

public class MyAppRootPresenter extends RootPresenter {

    public static final class MyRootView extends RootView {
        @Override
        protected RootPanel getAppRootPanel() {
            return RootPanel.get("appPanel");
        }
    }

    @Inject
    public MyAppRootPresenter(final EventBus eventBus, final MyRootView myRootView) {
        super(eventBus, myRootView);
    }
}

[christiangoudreau]

What about the rootlayoutpanel?

[clavelm]

The RootLayoutPanel is added to the RootPanel.
RootPresenter.java, line 87

getAppRootPanel().add(RootLayoutPanel.get());

I just learned today about RootPanel and RootLayoutPanel, my pull request might not be working for every situation.
It would be working for my app that is only using the RootPanel.

[branflake2267]

Thanks for digging into this. :)

[christiangoudreau]

True, it been so long since I looked at this code! Thanks for the contribution :D

[christiangoudreau]

Why did you changed that to final?

[clavelm]

My eclipse is configured to add final on file save.
I didn't cancel it before saving the file.

[christiangoudreau]

Remove them please, this is the only nits that I have, afterward LGTM

[clavelm]

I'm preparing a new commit to that pull request by removing the final added in that commit.
I'm just wondering why there are final on the parameters of the class constructor but not on the parameters of the other methods ?
By the way, should I remove only the final on this method parameters, or all that where added by eclipse when saving the file ?

[christiangoudreau]

Old code, we're not adding them to Ctor as well anymore

[clavelm]

Ok, I just added a commit removing the 'final' modifiers.

[branflake2267]

LGTM, nice job!