Fix issue #201: GenProxyProcessor and Lists (Second try) #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move tests for gwtp-processors project from gwtp-dispatch-shared to correct project. Refactor big test into several smaller tests each testing one specific generator.
If a field has a UseProxy annotation and is of type List or Set, then in the generated Proxy class this field (and its getters and setters) will also be of type List or Set. Extending test case for both scenarios; unfortunately it's not possible to test if the generic type of the List or Set has been generated correctly.
|
@branflake2267 Now it looks better, right? |
|
Commits look great, thanks :) |
|
|
||
| @Test | ||
| public void shouldGenerateDispatchWithOptionalFields() { | ||
| RetrieveFooAction action = new RetrieveFooAction.Builder(42).additionalQuestion("meaning of life").build(); |
There was a problem hiding this comment.
lol, I like the test number and meaning :)
There was a problem hiding this comment.
Yeah, but I can't take credit for it; the code was already there ;-)
…er Set or List interface Adapt tests accordingly.
|
LGTM |
christiangoudreau
added a commit
that referenced
this pull request
Jul 4, 2013
Fix issue #201: GenProxyProcessor and Lists (Second try)
christiangoudreau
added a commit
that referenced
this pull request
Apr 4, 2014
Fix issue #201: GenProxyProcessor and Lists (Second try)
hpehl
pushed a commit
to hpehl/GWTP
that referenced
this pull request
Dec 9, 2014
Fix issue ArcBees#201: GenProxyProcessor and Lists (Second try) Former-commit-id: 798a0d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #201; additionally tests for gwtp-processors have been moved from gwtp-dispatch-shared to their correct project (the maven dependencies also needed to be reverted for this)