Fix issue #201: GenProxyProcessor and Lists #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move tests for gwtp-processors from gwtp-dispatch-shared and reverse test dependency Split AnnotationProcessingTest into four different Tests each testing one Generator
… Set or List then a Set or List of this class is generated into the Proxy class Add tests for proving the behaviour (unfortunately it is not possible to test for the generic type in the compiled class)
|
Can you catch this up with master? |
|
I hope, I did it right now. Otherwise I need to re-create the pull-request. |
|
I suspect that a fetch and merge with forked remote/master instead of the your remote/master. I see commits from me still. If using eclipse, a remote can be added to fetch and merge with in the git configuration. Or I often manually edit the .git config file so I can fetch and merge with different remote branches. |
|
Ok, trying again tomorrow; and closing this pull-request, as it seems not fixable (at least not for me) |
|
Sounds good. Thanks for trying :) |
| @@ -21,7 +21,27 @@ | |||
| <proc>none</proc> | |||
| </configuration> | |||
| </plugin> | |||
|
|
|||
| <plugin> | |||
|
I'm eager to see those changes in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #201; additionally tests for gwtp-processors have been moved from gwtp-dispatch-shared to their correct project (the maven dependencies also needed to be reverted for this)