Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PresenterWidget.fireEvent() to support generic Event #668

Closed
timeu opened this issue Jan 25, 2015 · 2 comments
Closed

Extend PresenterWidget.fireEvent() to support generic Event #668

timeu opened this issue Jan 25, 2015 · 2 comments
Assignees

Comments

@timeu
Copy link
Contributor

timeu commented Jan 25, 2015

Currently the fireEvent() function support only GwtEvent<?> as paramter.
GwtEvent extends from Event.

According to http://www.gwtproject.org/javadoc/latest/com/google/gwt/event/shared/GwtEvent.html one should use Event instead of GwtEvent:

There is no need for an application's custom event types to extend GwtEvent. Prefer Event instead.

It would be handy if the fireEvent function would be extended to support the more generic Event type.

The current workaround is: getEventBus().fireEventFromSource(new MyEvent(),this);

@rdwallis
Copy link
Contributor

@timeu thanks for reporting. Can you implement and do a PR for this?

@timeu
Copy link
Contributor Author

timeu commented Jan 25, 2015

Sure,
I forked it and tried to run mvn clean test but apparently it can't find the arcbees-checkstyle configuraiton:
Failure to find com.arcbees:checkstyle:jar:1.0-SNAPSHOT

Any pointers how to fix it ?

Chris-V added a commit that referenced this issue Jan 27, 2015
Added fireEvent(Event<?>) overload to address issue #668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants