aravis-tools: Correct appstream metainfo description and file name #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Petter Reinholdtsen <[email protected]>
EmmanuelP
requested changes
Sep 3, 2024
viewer/data/meson.build
Outdated
| @@ -4,7 +4,7 @@ appdata_conf = configuration_data() | |||
| appdata_conf.set ('ARAVIS_API_VERSION', aravis_api_version) | |||
|
|
|||
| configure_file (input: files('org.aravis.viewer.appdata.xml.in'), | |||
| output: 'org.aravis.viewer-@[email protected].xml'.format (aravis_api_version), | |||
| output: 'org.aravis.viewer.metainfo.xml'.format (aravis_api_version), | |||
There was a problem hiding this comment.
Different aravis series are supposed to be installable in parallel. This change breaks this possibility.
There was a problem hiding this comment.
Understood!
The last commit should have fixed this issue, right?
There was a problem hiding this comment.
nope... I have to modify the id tag too... :) coming soon...
EmmanuelP
approved these changes
Sep 3, 2024
|
Thanks Chiara. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear aravis maintainers,
this pull request fixes a bug reported during debian packaging, applying the patch offered by @petterreinholdtsen.
It corrects appstream metainfo validation errors, adding missing
<p>to description and making sure file name match ID.Also it uses the new
metainfo.xmlending replacing the obsoleteappdata.xmlending.Thanks for considering it.