Workaround for BlackFly U16 pixel endianness issues #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have pushed a slightly edited version of your patch. Thanks a lot. |
|
Thank you, I've tested your edited version and it works as well. BTW I'm also using aravis as a library, this fix only applies to the viewer and I still have to byte-swap the data in my code. Not a big deal in this case, but IMHO it would have been better to handle this when the images are pushed to the ArvStream. |
|
I have deliberately avoided any data conversion in aravis library code. It is out of the scope of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #922
As requested, only arvmisc and arvviewer were modified, endianness is handled by the gstreamer plugin.