Disable Leader packet timeout #746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks for the patch. I think the test is incomplete, current_frame can point to a previous frame, for example if a resent packet is received. |
|
Thanks for the feedback. |
EmmanuelP
pushed a commit
that referenced
this pull request
Feb 27, 2023
Don't start frame timeout on leader packet reception, as it could have been sent early, at acquisition start. https://aravis-project.discourse.group/t/external-triggering-of-spectral-instruments/548
|
Pushed to main. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#732
https://aravis-project.discourse.group/t/external-triggering-of-spectral-instruments/548
Frames will no longer timeout after expiration of the frame_retention_timeout period if the ONLY packet received so far is a leader packet.