Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/703/multiple taps #745

Merged
merged 14 commits into from
Mar 10, 2023

Conversation

hackel6
Copy link
Contributor

@hackel6 hackel6 commented Dec 15, 2022

@EmmanuelP
Copy link
Contributor

Hi,

Sorry for the late reply.

I don't think we can select gain or black level using defined integer values. There is no guarantee a selector value is always mapped to the same string.

arv_camera_select_gain and arv_camera_select_black_level should use a string as the selector parameter.

@EmmanuelP EmmanuelP marked this pull request as draft January 9, 2023 10:37
@EmmanuelP EmmanuelP force-pushed the enhancement/703/multiple-taps branch from 74bbb41 to 4566022 Compare January 9, 2023 16:04
src/arvcamera.c Outdated Show resolved Hide resolved
src/arvcamera.c Outdated Show resolved Hide resolved
@hackel6
Copy link
Contributor Author

hackel6 commented Jan 17, 2023

@EmmanuelP, is this at least more of what you had in mind? raw strings? i guess it doesn't buy you all that much now since it just wraps to the arv_camera_set_string() method.

@hackel6 hackel6 marked this pull request as ready for review January 17, 2023 22:36
Copy link
Contributor

@EmmanuelP EmmanuelP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.

It looks good. Please update the Since statements in the function documentation.

@hackel6 hackel6 requested a review from EmmanuelP March 10, 2023 19:26
@EmmanuelP EmmanuelP merged commit 9756369 into AravisProject:main Mar 10, 2023
@EmmanuelP
Copy link
Contributor

Thanks.

@hackel6 hackel6 deleted the enhancement/703/multiple-taps branch March 10, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants