Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gst: Add GstQueryLatency handling #686

Merged

Conversation

TIS-Edgar
Copy link
Contributor

Define maximum latency and GST_CLOCK_TIME_NONE to prevent timeouts.

Potential fix for #528.

All gstreamer sources must be synchronized with the gstreamer clock.
Since aravissrc is a live source it can't give reliable increasing timestamps and instead works with durations.
Ideally that would mean first timestamp (0) + duration of frame. New timestamp + duration of frame, etc.
Since we cannot know what the duration of a frame is (some come faster, some slower, thus never being 100% accurate) gstreamer wants to know a latency range.
This patch defined the latency as min=framerate and max=GST_CLOCK_TIME_NONE.
That basically says expect the next buffer between average duration and any given time in the future after that,
users more than enough time to trigger, extended exposure times, etc.

Define maximum latency and GST_CLOCK_TIME_NONE to prevent timeouts.
@TIS-Edgar
Copy link
Contributor Author

I have no clue why the Aravis-MSVC check fails with

source_subfolder\meson.build:291:0: ERROR: Dependency 'glib-2.0' is required but not found.

@EmmanuelP
Copy link
Contributor

I have no clue why the Aravis-MSVC check fails with

source_subfolder\meson.build:291:0: ERROR: Dependency 'glib-2.0' is required but not found.

Don't worry about that, this pipeline is failing for a while now, probably due to a change in the build environment.

@EmmanuelP EmmanuelP merged commit af9a095 into AravisProject:main Jul 7, 2022
@EmmanuelP
Copy link
Contributor

Thanks Edgar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants