Allow controlling the disposal of provided transport and HTTP client instances #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossmills99
reviewed
Dec 17, 2023
Collaborator
Author
|
@rossmills99 PR updated according to your proposed improvement to use Mock. Thank you 👍 Also rebased on master. |
DiscoPYF
commented
Dec 22, 2023
DiscoPYF
force-pushed
the
control-disposal
branch
from
3299647 to
da8cdda
Compare
DiscoPYF
force-pushed
the
control-disposal
branch
from
da8cdda to
0a598db
Compare
rossmills99
approved these changes
Jan 3, 2024
Collaborator
rossmills99
left a comment
rossmills99
left a comment
There was a problem hiding this comment.
Nice update, this will save some headaches/workarounds, thanks @DiscoPYF .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #481