Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all viewable items in MEStorageMenus to Emi inventory #8215

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ramidzkh
Copy link
Contributor

Also fixes a bug where items in the crafting terminal grid would disappear from the tree

Closes #8214

@theboo
Copy link

theboo commented Nov 2, 2024

So i made a build against this PR (1.21 neo) threw it on my family e10 server(i am a contributor over at enigmatica), and it seems to work fairly well as far as showing what items you have vs synthetic favorites. Does not take much time at all for emi to see what is available for the synthetic faves. My one issue is the "craft on/all to inventory/cursor" keybinds that are part of this do not seem to work while in the crafting terminal. This feature is really what makes the BOM/Synthetic system so powerful. Two gifs below show what happens when i craft using synthetic favorites in a vanilla crafting table vs what happens in ae2 using the same hotkey, crafting 4ea 4k item storage cells(notice how fast i am able to craft the 4k cells using the vanilla table).
Vanilla table:
https://gyazo.com/8f22133858af7aa8434f02db5ccb168a
Crafting Terminal(notice how quickly EMI is able to recognize what is available in the ME system, but i cannot craft to either inventory with my hotkeys like previous gif):
https://gyazo.com/7fe814aa07e2079e6ed50e9ab2431b3c

@theboo
Copy link

theboo commented Nov 4, 2024

After using this PR on my family server for the whole weekend, i can say i didnt have any sort of noticeable performance issues(ofc this should be tested by others, and im sure it would be before it makes it to a release lol. I did not do any objective testing through spark profile or otherwise)...

Missing the hot key support ended up not being as big of a deal as i thought(PR is still AMAZING without it plus i think that is covered in a different issue entirely), was only mostly annoying if crafting something just under a stack and you have the resources to craft more(emi hotkeys will craft the exact amount you need when using "craft all") so you end up either shift clicking to craft a stack which over-crafts what you need, or you just play cookie clicker for a bit to get the amount you need. Other than that, i think this PR is an amazing addition, could be something that is off by default with a toggle in the terminal settings if performance ends up being an issue(assuming client side performance degradation as its EMI storing all the info on the client, if server performance it would have to be a server or common config for the toggle ofc).

Sorry if this input is not wanted here, will be my last comment on it unless asked for more input haha. Thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMI BOM (synthetic favourites) support
2 participants