Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMI BOM (synthetic favourites) support #8214

Open
jeytee84 opened this issue Oct 17, 2024 · 5 comments · May be fixed by #8215
Open

EMI BOM (synthetic favourites) support #8214

jeytee84 opened this issue Oct 17, 2024 · 5 comments · May be fixed by #8215

Comments

@jeytee84
Copy link

jeytee84 commented Oct 17, 2024 •
edited
Loading

Reasons why it should be considered

The recipe tree and the generated bill of materials in EMI are some of the best QoL features in expert modpacks like GregTech. Having it before accessing an ME system is a treat, but losing it once you get ME access is quite sad.

Describe the feature

This mod add this functionality, but it's only for fabric.
https://www.curseforge.com/minecraft/mc-mods/ae2-emi-crafting-integration/files/5160115
emilyploszaj/emi#696 (comment)

EMI supports this, AE2 does not
@ramidzkh ramidzkh linked a pull request Oct 17, 2024 that will close this issue
Open
@shartte
Copy link
Member

shartte commented Oct 17, 2024 via email

@jeytee84
Copy link
Author

maybe a config option for it?

@ramidzkh
Copy link
Contributor

The addon doesn't seem to do much differently in this area?
https://github.com/blocovermelho/ae2-emi-crafting/blob/master/src/main/java/org/blocovermelho/ae2emicrafting/client/handler/generic/Ae2BaseRecipeHandler.java#L56-L59
https://github.com/blocovermelho/ae2-emi-crafting/blob/master/src/main/java/org/blocovermelho/ae2emicrafting/client/helper/InventoryUtils.java#L26

The only performance downgrade I could see is the refresh every 400ms/50ms (when a recipe is open), requiring all the stacks to be iterated and such. I could try to do some investigation if that was it @shartte

@jeytee84
Copy link
Author

jeytee84 commented Oct 21, 2024 •
edited
Loading

I've been testing it for an hour now, works just fine through Sinytra Connector as detailed here, it could totally be at least an option disabled by default.

@jeytee84 jeytee84 mentioned this issue Oct 27, 2024
Closed
@theboo
Copy link

theboo commented Nov 2, 2024 •
edited
Loading

i could see craftables causing a massive performance hit... but the synthetic faves shouldnt be too bad? really sad when i made my ae2 terminal in e10 and found i could no longer use my craft one/all to inventory EMI hotkeys while in my ME system crafting terminal. Seemed weird cuz when i hover over the items in my synthetic faves, the tooltip can already see if i have the items needed for the craft, so EMI is seeing what is in the ME system somehow already...

@theboo theboo mentioned this issue Nov 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add all viewable items in MEStorageMenus to Emi inventory ramidzkh/Applied-Energistics-2
4 participants
@shartte @theboo @ramidzkh @jeytee84