Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--appimage-version is empty #103

Closed
probonopd opened this issue Dec 7, 2024 · 1 comment · Fixed by #104
Closed

--appimage-version is empty #103

probonopd opened this issue Dec 7, 2024 · 1 comment · Fixed by #104
Labels
bug Something isn't working

Comments

@probonopd
Copy link
Member

As noticed by @brunvonlope:

Running --appimage-version in appimages generated by appimagetool gives no output:

AppImage runtime version:

@probonopd probonopd added the bug Something isn't working label Dec 7, 2024
@probonopd
Copy link
Member Author

probonopd commented Dec 7, 2024 •
edited
Loading

This is how it is supposed to work (it works there):

https://github.com/search?q=repo%3Aprobonopd%2Fstatic-tools+src%2Fruntime%2Fversion&type=code

Looks like we might be missing the export GIT_COMMIT=$(cat src/runtime/version)?

probonopd added a commit that referenced this issue Dec 7, 2024
@probonopd
export GIT_COMMIT=$(cat src/runtime/version)
4062c0a 
Closes #103
@probonopd probonopd mentioned this issue Dec 7, 2024
Merged
probonopd added a commit that referenced this issue Dec 8, 2024
@probonopd
export GIT_COMMIT=$(cat src/runtime/version) in Makefile
c9887dd 
Closes #103
probonopd added a commit that referenced this issue Dec 8, 2024
@probonopd
export GIT_COMMIT=$(cat src/runtime/version) in Makefile (#104)
68953fd 
Closes #103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --appimage-version AppImage/type2-runtime
1 participant
@probonopd