Repository navigation
fix: hide Present button until explicitly enabled - #688
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideTemporarily hides the Present button across document, full-page row, and page-modal headers through a shared disabled-by-default feature flag, with documentation explaining how to re-enable it. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/components/presentation/README.md" line_range="5" />
<code_context>
This feature provides **Present document**, **Present AI mind map**, and **AI Slides** in the signed-in app. Document presentation uses a read-only editor snapshot; AI operations use authenticated AppFlowy Cloud presentation APIs.
+The **Present** button is temporarily hidden in page and modal headers. Keep `PRESENTATION_ENTRY_ENABLED` in [`feature-flags.ts`](./feature-flags.ts) set to `false` until explicitly asked to enable it.
+
## Run locally
</code_context>
<issue_to_address>
**README points to hidden button**
When a reader follows the presentation README while the flag is false, `feature-flags.ts` sets the flag to `false`, but the README still says “Present beside Share opens” the presentation options. Readers following that instruction cannot find the entry point in page or modal headers.
Qualify or remove the README bullet that says Present is available beside Share while the entry point is disabled.
</issue_to_address>|
|
||
| This feature provides **Present document**, **Present AI mind map**, and **AI Slides** in the signed-in app. Document presentation uses a read-only editor snapshot; AI operations use authenticated AppFlowy Cloud presentation APIs. | ||
|
|
||
| The **Present** button is temporarily hidden in page and modal headers. Keep `PRESENTATION_ENTRY_ENABLED` in [`feature-flags.ts`](./feature-flags.ts) set to `false` until explicitly asked to enable it. |
There was a problem hiding this comment.
⚪ Low · README points to hidden button
When a reader follows the presentation README while the flag is false, feature-flags.ts sets the flag to false, but the README still says “Present beside Share opens” the presentation options. Readers following that instruction cannot find the entry point in page or modal headers.
Qualify or remove the README bullet that says Present is available beside Share while the entry point is disabled.
Prompt for AI agents
In `src/components/presentation/README.md` at line 5:
**README points to hidden button**
When a reader follows the presentation README while the flag is false, `feature-flags.ts` sets the flag to `false`, but the README still says “Present beside Share opens” the presentation options. Readers following that instruction cannot find the entry point in page or modal headers.
Qualify or remove the README bullet that says Present is available beside Share while the entry point is disabled.…access hints (#689) - Load failures in the slides dialog use a centered AppFlowy error state (icon, title, message, Back to page / Retry buttons) instead of left-aligned text with legacy buttons. - A presented mind map or document that cannot load closes and shows an AppFlowy toast instead of a full-screen error page. Mind map empty states use the same centered component. - The header Present button (hidden for everyone by #688) now shows only on official AppFlowy Cloud: usePresentationEntryEnabled() follows useIsOfficialHosted(), so self-hosted servers never see it. - In the Present menu, AI mind map and AI ppt stay visible but unavailable for workspace guests (the server requires a member or owner) and for users without edit access to the page, with the reason shown on hover/focus. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Description
Hide the Present button from document, full-page row, and page-modal headers until explicitly enabled. Both header entry points use a shared
PRESENTATION_ENTRY_ENABLED = falseflag, with the re-enable instruction documented in the presentation README.Validation
pnpm type-checkpassed.localhost:3000, including a reload ignoring cache: Present is absent and Share remains visible.Checklist
General
Testing
Feature-Specific
Summary by Sourcery
Temporarily hide the Present entry point across supported headers until it is explicitly re-enabled.
Enhancements:
Documentation:
Chores: