feat: allow underscore in publish url #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasXu0
reviewed
Nov 15, 2024
| @@ -74,7 +74,7 @@ fn check_collab_publish_name(publish_name: &str) -> Result<(), AppError> { | |||
|
|
|||
| // Only contain alphanumeric characters and hyphens | |||
| for c in publish_name.chars() { | |||
| if !c.is_alphanumeric() && c != '-' { | |||
| if !c.is_alphanumeric() && c != '-' && c != '_' { | |||
There was a problem hiding this comment.
should we use regex to handle it?
There was a problem hiding this comment.
If we there is more complicated pattern (like email) that we want to enforce, I think it would be worth to add it in. For now, this is good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.