-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs for Raspberry Pi Docker instructions #560
update docs for Raspberry Pi Docker instructions #560
Conversation
Since Docker now supports multi-arch images, separate Dockerfile for ARM builds is no longer necessary. It'd be best, if the project provided official builds for at least arm32v7, too. |
@Erovia Thanks for the info, I will look into it tomorrow and if you are right, I will update my PR with the appropriate documentation. |
@tseho - thanks for this. Is your update still pending or shall I merge as is? |
@acockburn I haven't tried yet, the test should be quick, I will launch it tonight and will get back to you asap. |
@Erovia was right, there is no need to specify the |
@acockburn I updated it. |
@acockburn, do you think it would be possible the provide armhf builds of AppDaemon on your Docker Hub repo? It can be an automated build, with some extra work: docker/hub-feedback#1261 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does work fine, though couldn't get mine to start, but the image was build without errors
@Odianosen25 I'm sorry to hear that. I want to be sure it's working for everyone. Can you provide more informations so I can try to reproduce the error ? |
Well I am not sure where it messed up, as I am not a docker user, but had to check that it works. So as I said it all built fine, but I think the issue is just my own system as my code needed
This I wouldn't imagine affects others, so based on that didn't think there was any need stopping merging it. If I was fluent in docker, maybe I can. But unfortunately I am not. So if you can point me in the right direction, that will be great. I know for And its for the Raspberry Pi Thanks |
Assuming the official docker image for appdaemon will support the multi-arch builds in the future, I will not recommend to change the original Dockerfile. What I would do, if I were in your case, would be the following:
Once the hack for building the official docker image on the arm32v7 arch is done, Then, I would create a custom Dockerfile in another directory, eg:
Now, you can build/run the custom image like this :
This is a specific use case, I don't think we should pollute the documentation with it 😉 |
Thanks @tseho, I agree with that, and that’s why I didn’t bother and merged. Thanks for the update and kind regards |
I updated the Raspberry Pi Docker instructions on
docs/INSTALL.rst
since they were outdated.The most important change is to use
FROM arm32v7/python:3.6-alpine
instead ofFROM arm32v7/python:3.6
because the image has been changed to alpine in #486.