Skip to content

Fix flaky test - #3231

Merged
martincostello merged 1 commit into
mainfrom
fix-flaky-test
Sep 12, 2026
Merged

martincostello merged 1 commit into
mainfrom
fix-flaky-test

Conversation

@martincostello

@martincostello martincostello commented Sep 12, 2026

Copy link
Copy Markdown
Member

Fix flaky test if there's a race in the shared pool between parallel test executions.

Fix flaky test if there's a race in the shared pool between parallel test executions.
@martincostello
martincostello marked this pull request as ready for review September 12, 2026 10:45
Copilot AI lite review requested due to automatic review settings September 12, 2026 10:45
@martincostello
martincostello enabled auto-merge (squash) September 12, 2026 10:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The FakeTimeProvider assertion will fail deterministically on .NET 8+ until corrected.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This pull request isolates cancellation-token pool tests from the shared process-wide pool to prevent race-related flakiness.

Changes:

  • Uses a dedicated pool for reusable-pool tests.
  • Exposes the pooled implementation internally for testing.
  • The FakeTimeProvider reuse assertion still needs correction.
File summaries
File Summary
test/Polly.Core.Tests/Utils/CancellationTokenSourcePoolTests.cs Uses an isolated pool but contains an incorrect reuse assertion on pooled targets.
src/Polly.Core/Utils/CancellationTokenSourcePool.Pooled.cs Enables internal construction of the pooled implementation for tests.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/Polly.Core.Tests/Utils/CancellationTokenSourcePoolTests.cs
@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.02%. Comparing base (5f9fa58) to head (8a1dbab).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3231   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         321      321           
  Lines        7099     7099           
  Branches     1089     1089           
=======================================
  Hits         6959     6959           
  Misses         98       98           
  Partials       42       42           
Flag Coverage Δ
linux 97.97% <ø> (-0.05%) ⬇️
macos 98.01% <ø> (ø)
windows 98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@martincostello
martincostello merged commit 9ad5ae9 into main Sep 12, 2026
29 checks passed
@martincostello
martincostello deleted the fix-flaky-test branch September 12, 2026 10:56
This was referenced Sep 14, 2026
This was referenced Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants