Skip to content

Conversation

@martincostello
Copy link
Member

Switch to using GitHub OIDC for pushing packages to NuGet.org with Trusted Publishing.

Resolves #2742.

Switch to using GitHub OIDC for pushing packages to NuGet.org with Trusted Publishing.
@martincostello martincostello added CI/build dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Sep 22, 2025
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.15%. Comparing base (12a80e1) to head (fe1fd98).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2751   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files         309      309           
  Lines        7118     7118           
  Branches     1008     1008           
=======================================
  Hits         6844     6844           
  Misses        221      221           
  Partials       53       53           
Flag Coverage Δ
linux 96.15% <ø> (ø)
macos 96.15% <ø> (ø)
windows 96.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello marked this pull request as ready for review September 22, 2025 20:57
Copilot AI review requested due to automatic review settings September 22, 2025 20:57
@martincostello martincostello merged commit 03e3fc6 into main Sep 22, 2025
28 checks passed
@martincostello martincostello deleted the nuget-trusted-publishing branch September 22, 2025 20:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches from using a static API key to GitHub OIDC (OpenID Connect) for NuGet package publishing through GitHub's Trusted Publishing feature. This improves security by eliminating the need to store long-lived secrets.

  • Adds OIDC token permissions to the publish job
  • Integrates NuGet/login action for authentication via Trusted Publishing
  • Replaces static API key with dynamically generated token from the login step

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/build dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to NuGet trusted publishing

2 participants