Add AttemptNumber to HedgingPredicateArguments#2603
Merged
martincostello merged 3 commits intoApp-vNext:mainfrom May 4, 2025
Merged
Add AttemptNumber to HedgingPredicateArguments#2603martincostello merged 3 commits intoApp-vNext:mainfrom
martincostello merged 3 commits intoApp-vNext:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7327 7329 +2
Branches 1013 1013
=======================================
+ Hits 7051 7053 +2
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
test/Polly.Core.Tests/Hedging/HedgingPredicateArgumentsTests.cs
Outdated
Show resolved
Hide resolved
Member
|
Looks like we don't have an "end-to-end" test change anywhere that asserts that the attempt number correctly increments. |
martincostello
approved these changes
May 4, 2025
This was referenced May 4, 2025
Merged
Contributor
|
Thanks for your contribution @peter-csala - the changes from this pull request have been published as part of version 8.6.0 📦, which is now available from NuGet.org 🚀 |
This was referenced Nov 24, 2025
Open
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Dec 22, 2025
This was referenced Jan 1, 2026
Closed
This was referenced Jan 8, 2026
Closed
Merged
This was referenced Jan 16, 2026
Closed
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
#2602
Details on the issue fix or feature implementation
The API is not the most convenient, but backward compatible.
Confirm the following