Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 309 309
Lines 7127 7128 +1
Branches 1005 1005
=======================================
+ Hits 6853 6854 +1
Misses 221 221
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Remove explicit reference to System.Text.Json as it should be redundant. Identified by #2531.
Remove explicit reference to System.Text.Json as it should be redundant. Identified by #2531.
6980d6b to
fb10ae1
Compare
1a4af4a to
37450b6
Compare
Fix more IDE0055 warnings from #2531.
2e22949 to
e8b0126
Compare
847e149 to
20768ae
Compare
20768ae to
235a3d1
Compare
d2bebec to
7de741f
Compare
Cherry-pick changes from #2531 to sort package versions and add new references.
Cherry-pick changes from #2531 to sort package versions and add new references.
83c93f8 to
f05acbd
Compare
0d6763c to
0b3d12b
Compare
Update to latest beta version.
Fix build due to conflicting reference from Cake.Sdk.
Update to the stable version of .NET 10.
|
Depends on stryker-mutator/stryker-net#3327. |
Suppress IDE0032 until Stryker supports .NET 10 and C# 14 and #2531 can be merged.
* Update .NET SDK Update .NET SDK to version 9.0.308. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-version: 9.0.308 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> * Suppress IDE0032 Suppress IDE0032 until Stryker supports .NET 10 and C# 14 and #2531 can be merged. * Fix mutation tests Try to prevent stryker from rolling forward to the .NET 10 SDK. --------- Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> Co-authored-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> Co-authored-by: Martin Costello <[email protected]>
Cherrypick some changes from #2531 while that is blocked on a new release of Stryker that supports .NET 10 GA.
Cherrypick some changes from #2531 while that is blocked on a new release of Stryker that supports .NET 10 GA.
This is closed as completed now and a new version of Stryker is published, seems like there's been a few reported issues though. |
Otherwise `field` generates an error.
There was a problem hiding this comment.
Pull request overview
This PR updates the project to build and test with the .NET 10 SDK while maintaining backward compatibility. The update includes adopting C# 14 features and modernizing the build system with Cake.Sdk.
- Updates .NET SDK from 9.0.308 to 10.0.100
- Adds
net10.0target framework to test, benchmark, and sample projects - Adopts C# 14 semi-auto properties with
fieldkeyword - Migrates build scripts to use Cake.Sdk
- Removes explicit System.Text.Json package references (included in .NET 10 framework)
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updates SDK version to 10.0.100 and adds Cake.Sdk 6.0.0 reference |
| cake.cs | Migrates to Cake.Sdk format with new directive syntax and removes unused helper function |
| build.ps1 | Updates script name reference from build.cake to cake.cs and adjusts dotnet command invocation |
| bench/benchmarks.ps1 | Updates benchmark framework target from net9.0 to net10.0 |
| bench/Polly.Core.Benchmarks/Polly.Core.Benchmarks.csproj | Adds net10.0 to target frameworks |
| bench/Polly.Benchmarks/Polly.Benchmarks.csproj | Adds net10.0 to target frameworks |
| test/*.csproj (6 files) | Adds net10.0 to test project target frameworks |
| test/Polly.AotTest/Polly.AotTest.csproj | Updates single target framework from net9.0 to net10.0 |
| samples/*.csproj (5 files) | Updates sample project target frameworks from net9.0 to net10.0 |
| src/Snippets/Snippets.csproj | Updates target framework to net10.0 and removes System.Text.Json package reference |
| samples/Chaos/Chaos.csproj | Updates target framework to net10.0 and removes System.Text.Json package reference |
| src/Polly/Context.Dictionary.cs | Refactors to use C# 14 semi-auto property with field keyword |
| test/Polly.Specs/Helpers/Bulkhead/TraceableAction.cs | Refactors Status property to use C# 14 semi-auto property with field keyword |
| Directory.Packages.props | Removes System.Text.Json package version and adds net10.0-specific package version overrides |
| eng/stryker-config.json | Updates target framework to net10.0 and sets language version to Preview |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Disable including passed tests to fix the step summaries being too large since the upgrade to GitHubActionsTestLogger v3.
Update to the latest release.
| { | ||
| "sdk": { | ||
| "version": "9.0.308", | ||
| "version": "10.0.100", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I know - it's just an old PR as it was waiting on the stryker fix. Automation can update it post merge anyway.
Update to build and test with .NET 10. net10.0 is explicitly not being added as a new TFM for the packages we ship to NuGet.org.
Changes include:
net10.0to the test projects.Cake.Sdk.