Skip to content

Add missing mutations#2508

Merged
martincostello merged 9 commits intomainfrom
add-missing-mutations
Feb 17, 2025
Merged

Add missing mutations#2508
martincostello merged 9 commits intomainfrom
add-missing-mutations

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Feb 17, 2025

  • Add tests for the remaining undetected mutations.
  • Remove remaining explicit doNothing delegate allocations.
  • Increase mutation score for Polly to 100.
  • Increase minimum code coverage for Polly.Specs to ~90%.

- Add missing code coverage for retry policies.
- Avoid allocating empty delegates.
Avoid allocating empty delegates.
@martincostello martincostello added enhancement CI/build .NET Pull requests that update .NET code labels Feb 17, 2025
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.09%. Comparing base (9190943) to head (b1b3c4c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Polly/Retry/AsyncRetryTResultSyntax.cs 85.71% 1 Missing ⚠️
src/Polly/Retry/RetrySyntax.cs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2508      +/-   ##
==========================================
+ Coverage   90.76%   94.09%   +3.32%     
==========================================
  Files         311      311              
  Lines        7484     7431      -53     
  Branches     1070     1043      -27     
==========================================
+ Hits         6793     6992     +199     
+ Misses        543      342     -201     
+ Partials      148       97      -51     
Flag Coverage Δ
linux 94.09% <95.23%> (+3.32%) ⬆️
macos 94.09% <95.23%> (+3.32%) ⬆️
windows 94.07% <95.23%> (+3.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add missing coverage for retry and timeout.
Fix three S3257 warnings, two of which are false positives.
Add more missing code coverage.
Add more missing coverage for edited files.
Add some further missing coverage.
Add two remaining uncovered async fallback coverage branches.
- Increase code coverage thresholds after new tests added.
- Increase mutation score for Polly to 100.
@martincostello martincostello marked this pull request as ready for review February 17, 2025 16:03
@martincostello martincostello enabled auto-merge (squash) February 17, 2025 16:03
@martincostello martincostello merged commit 4469d83 into main Feb 17, 2025
26 checks passed
@martincostello martincostello deleted the add-missing-mutations branch February 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/build enhancement .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant