Merged
Conversation
- Fix Polly.Testing mutation tests not returning any results. - Kill surviving mutants to get 100%.
Use a new file when patching the Stryker configuration file to avoid editing the file in the Git tree.
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
test/Polly.Testing.Tests/ResiliencePipelineExtensionsTests.cs:22
- Ensure that the error message 'pipeline' is clear and helpful. Consider adding a custom message to indicate that the pipeline parameter cannot be null.
Should.Throw<ArgumentNullException>(() => pipeline.GetPipelineDescriptor()).ParamName.ShouldBe("pipeline");
test/Polly.Testing.Tests/ResiliencePipelineExtensionsTests.cs:23
- Ensure that the error message 'pipeline' is clear and helpful. Consider adding a custom message to indicate that the pipeline parameter cannot be null.
Should.Throw<ArgumentNullException>(() => pipelineGeneric.GetPipelineDescriptor()).ParamName.ShouldBe("pipeline");
src/Polly.Testing/ResiliencePipelineExtensions.cs:79
- The line
components.Add(tracking);was removed. This changes the behavior of the method by not addingExecutionTrackingComponentto thecomponentslist. If this component is expected to be part of the list, this could lead to issues.
ExpandComponents(tracking.Component, components);
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2503 +/- ##
=======================================
Coverage 85.35% 85.36%
=======================================
Files 312 312
Lines 7465 7468 +3
Branches 1121 1121
=======================================
+ Hits 6372 6375 +3
Misses 908 908
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Nov 24, 2025
Open
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
Closed
This was referenced Dec 29, 2025
Closed
This was referenced Jan 5, 2026
Closed
This was referenced Jan 12, 2026
Merged
Closed
This was referenced Jan 19, 2026
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #2500 I noticed that no mutations were being tested for Polly.Testing.
This fixes that by removing the
ignore-mutationssetting for that project, otherwise Stryker finds no ways to mutate the code and does nothing.Once that was fixed, some additional changes were needed to get back to 100% mutations score for that project.