Skip to content

Fix potential github action smells #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2024
Merged

Fix potential github action smells #2097

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ffa30b7
Fix gha smells:
ceddy4395 May 4, 2024
a527256
Replace github.repository with github.event.repository.fork
ceddy4395 May 13, 2024
29df784
Remove trailing space
ceddy4395 May 13, 2024
d832365
Revert preventing uploading artifacts on forks
ceddy4395 May 13, 2024
f78d0fd
Fix formatting
martincostello May 13, 2024
7415ae8
Disable workflows on forks
martincostello May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/after-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

update-changelog:
runs-on: [ ubuntu-latest ]
if: github.event_name == 'release'
if: github.event_name == 'release' && github.event.repository.fork == false

concurrency:
group: '${{ github.workflow }}-changelog'
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
concurrency:
group: '${{ github.workflow }}-milestone'
cancel-in-progress: false

if: github.event.repository.fork == false
permissions:
issues: write

Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
run: ./build.ps1

- name: Upload Coverage Reports
if: always()
if: always() && github.event.repository.fork == false
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: coverage-${{ matrix.os_name }}
Expand All @@ -86,19 +86,21 @@ jobs:

- name: Upload coverage to Codecov
uses: codecov/codecov-action@5ecb98a3c6b747ed38dc09f787459979aebb39be # v4.3.1
if: always() && github.event.repository.fork == false
with:
files: ./artifacts/coverage-reports/Polly.Core.Tests/Cobertura.xml,./artifacts/coverage-reports/Polly.Specs/Cobertura.xml,./artifacts/coverage-reports/Polly.RateLimiting.Tests/Cobertura.xml,./artifacts/coverage-reports/Polly.Extensions.Tests/Cobertura.xml,./artifacts/coverage-reports/Polly.Testing.Tests/Cobertura.xml,
flags: ${{ matrix.os_name }}
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload Mutation Report
if: always() && env.RUN_MUTATION_TESTS == 'true'
if: always() && env.RUN_MUTATION_TESTS == 'true' && github.event.repository.fork == false
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: mutation-report
path: ./artifacts/mutation-report

- name: Publish NuGet packages
if: github.event.repository.fork == false
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: packages-${{ matrix.os_name }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-push-do-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
update-docs:
name: update-docs
runs-on: ubuntu-latest

if: github.repository == 'App-vNext/Polly'
steps:

- name: Generate GitHub application token
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions: {}
jobs:
release:
runs-on: [ ubuntu-latest ]

if: github.repository == 'App-vNext/Polly'
concurrency:
group: ${{ github.workflow }}
cancel-in-progress: false
Expand Down