Skip to content

Conversation

@martincostello
Copy link
Member

  • Build with the .NET 8 SDK.
  • Use new artifacts output.
  • Use C# 12 collection initializers where relevant. Suppress false positives when using TheoryData.
  • Remove some redundant code analysis suppressions.

Separates the .NET 8 upgrade in #1144 into using .NET 8 (this PR) and adding net8.0 support.

@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code CI/build labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (9967dc3) 84.56% compared to head (f314525) 84.54%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Polly/AsyncPolicy.ExecuteOverloads.cs 50.00% 6 Missing ⚠️
src/Polly/AsyncPolicy.TResult.ExecuteOverloads.cs 50.00% 3 Missing ⚠️
src/Polly/Policy.ExecuteOverloads.cs 75.00% 2 Missing ⚠️
src/Polly/Policy.TResult.ExecuteOverloads.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
- Coverage   84.56%   84.54%   -0.02%     
==========================================
  Files         308      308              
  Lines        6791     6783       -8     
  Branches     1044     1045       +1     
==========================================
- Hits         5743     5735       -8     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.54% <72.72%> (-0.02%) ⬇️
macos 84.54% <72.72%> (-0.02%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Copy link
Member Author

Reported docfx failures as dotnet/sdk#36539.

martincostello added a commit that referenced this pull request Oct 30, 2023
As discovered in #1738, there's an issue with Stryker with .NET 8 that breaks it on Linux and macOS, so run on Windows until that's resolved.
martincostello added a commit that referenced this pull request Oct 30, 2023
As discovered in #1738, there's an issue with Stryker with .NET 8 that breaks it on Linux and macOS, so run on Windows until that's resolved.
@martincostello martincostello force-pushed the dotnet-8-sdk branch 2 times, most recently from acdd331 to 104a2b9 Compare October 30, 2023 11:37
@martincostello
Copy link
Member Author

This should give a green build now, so we should be good to merge this once the 8.0.100 SDK is released.

@martincostello martincostello added this to the v8.2.0 milestone Oct 30, 2023
@martincostello martincostello force-pushed the dotnet-8-sdk branch 4 times, most recently from c1c298e to 7aeb647 Compare November 2, 2023 17:52
Build with the .NET 8 RC2 SDK.
Use new artifacts output.
- Use C#12 collection initializers where relevant.
- Suppress false positives when using `TheoryData`.
- Remove some redundant code analysis suppressions.
Resolve CP0001 and CP0002 warnings with the .NET 8 SDK.
Fix mutation tests by switching to Windows and updating the settings to support .NET 8 and C# 12.
- Fix NETSDK1204 error as cannot publish AoT on macOS.
- Fix NETSDK1201 error on Linux and Windows.
Use the stable release of the .NET 8 SDK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/build dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants