Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 28, 2023

Details on the issue fix or feature implementation

Contributes to #1301

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 28, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1447 (0aabfd3) into main (adb65f8) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1447   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         273      273           
  Lines        6505     6505           
  Branches     1010     1010           
=======================================
  Hits         5456     5456           
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.87% <100.00%> (ø)
windows 83.87% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/Polly.Core/Hedging/Controller/HedgingHandler.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/Controller/TaskExecution.cs 100.00% <100.00%> (ø)
...ly.Core/Hedging/HedgingActionGeneratorArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/HedgingDelayArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/OnHedgingArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/OnRetryArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/RetryDelayArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/RetryPredicateArguments.cs 100.00% <100.00%> (ø)
...y.Core/Telemetry/ExecutionAttemptArguments.Pool.cs 100.00% <100.00%> (ø)
.../Polly.Core/Telemetry/ExecutionAttemptArguments.cs 100.00% <100.00%> (ø)
... and 1 more

/// Initializes a new instance of the <see cref="ExecutionAttemptArguments"/> class.
/// </summary>
/// <param name="attempt">The execution attempt.</param>
/// <param name="attemptNumber">The execution attempt.</param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <param name="attemptNumber">The execution attempt.</param>
/// <param name="attemptNumber">The execution attempt number.</param>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants