-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycloak login #2302
Keycloak login #2302
Conversation
@@ -100,5 +100,6 @@ services: | |||
volumes: | |||
- ./config/keycloak/apicurio-realm.json:/opt/keycloak/data/import/apicurio-realm.json | |||
- ./config/keycloak/microcks-realm.json:/opt/keycloak/data/import/microcks-realm.json | |||
network_mode: host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this a problem but running the other components in host mode is ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Carles, thank you for reviewing. Because the 8080 port on the local machine has been occupied by the UI, if I'm not mistaken. Could you provide some pointers for better solutions?
@@ -39,7 +39,7 @@ APICURIO_UI_KC_CLIENT_ID=apicurio-studio | |||
APICURIO_UI_HUB_API_URL=http://localhost:8091 | |||
APICURIO_UI_EDITING_URL=ws://localhost:8092 | |||
APICURIO_UI_FEATURE_MICROCKS=true | |||
APICURIO_UI_VALIDATION_CHANNELNAME_REGEXP='([^\x00-\x20\x7f"'\''%<>\\^`{|}]|%[0-9A-Fa-f]{2}|\{[+#./;?&=,!@|]?((\w|%[0-9A-Fa-f]{2})(\.?(\w|%[0-9A-Fa-f]{2}))*(:[1-9]\d{0,3}|\*)?)(,((\w|%[0-9A-Fa-f]{2})(\.?(\w|%[0-9A-Fa-f]{2}))*(:[1-9]\d{0,3}|\*)?))*\})*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: we've gotta get rid of this or simplify it somehow. It's caused a number of issues...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Eric, thanks for reviewing. Are you referring to getting rid of the approach I used to modify the regular expression, or the original value itself that needs to be simplified?
Hi @carlesarnal ,
In this PR, I use
ports: - "8090:8080"
instead ofnetwork_mode: host
indocker-compose.apicurio.yml
. Now thelocalhost:8090
can be accessed and we can sign in Keycloak using the username and password in.env
.This will close #2262 .
Thank you for your review.