Keycloak login #2302
Closed
Keycloak login #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlesarnal
reviewed
Oct 23, 2023
| @@ -100,5 +100,6 @@ services: | |||
| volumes: | |||
| - ./config/keycloak/apicurio-realm.json:/opt/keycloak/data/import/apicurio-realm.json | |||
| - ./config/keycloak/microcks-realm.json:/opt/keycloak/data/import/microcks-realm.json | |||
| network_mode: host | |||
There was a problem hiding this comment.
why is this a problem but running the other components in host mode is ok?
There was a problem hiding this comment.
Hi Carles, thank you for reviewing. Because the 8080 port on the local machine has been occupied by the UI, if I'm not mistaken. Could you provide some pointers for better solutions?
| @@ -39,7 +39,7 @@ APICURIO_UI_KC_CLIENT_ID=apicurio-studio | |||
| APICURIO_UI_HUB_API_URL=http://localhost:8091 | |||
| APICURIO_UI_EDITING_URL=ws://localhost:8092 | |||
| APICURIO_UI_FEATURE_MICROCKS=true | |||
| APICURIO_UI_VALIDATION_CHANNELNAME_REGEXP='([^\x00-\x20\x7f"'\''%<>\\^`{|}]|%[0-9A-Fa-f]{2}|\{[+#./;?&=,!@|]?((\w|%[0-9A-Fa-f]{2})(\.?(\w|%[0-9A-Fa-f]{2}))*(:[1-9]\d{0,3}|\*)?)(,((\w|%[0-9A-Fa-f]{2})(\.?(\w|%[0-9A-Fa-f]{2}))*(:[1-9]\d{0,3}|\*)?))*\})*' | |||
There was a problem hiding this comment.
Side note: we've gotta get rid of this or simplify it somehow. It's caused a number of issues...
There was a problem hiding this comment.
Hi Eric, thanks for reviewing. Are you referring to getting rid of the approach I used to modify the regular expression, or the original value itself that needs to be simplified?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @carlesarnal ,
In this PR, I use
ports: - "8090:8080"instead ofnetwork_mode: hostindocker-compose.apicurio.yml. Now thelocalhost:8090can be accessed and we can sign in Keycloak using the username and password in.env.This will close #2262 .
Thank you for your review.