feat: add set_balance test provider API #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
previously approved these changes
Jun 23, 2022
|
We can better out-of-the-box support if this feat request is honored: Also, I will adjust + add more tests to |
fubuloubu
previously approved these changes
Jul 1, 2022
Comment on lines
+764
to
+765
| if isinstance(account, BaseAddress): | ||
| account = account.address # type: ignore |
There was a problem hiding this comment.
Doesn't self.conversion_manager.convert(account, AddressType) work here?
Comment on lines
+771
to
+772
| # Support hex strings | ||
| amount = int(amount, 16) |
There was a problem hiding this comment.
Isn't there a hex converter toint?
fubuloubu
reviewed
Jul 1, 2022
|
|
||
|
|
||
| def test_set_balance(chain, test_accounts): | ||
| with pytest.raises(APINotImplementedError): |
There was a problem hiding this comment.
Wait, does eth-tester not support this method?
There was a problem hiding this comment.
It didnt seem like it but i created an issue for them
Comment on lines
+382
to
+383
| @raises_not_implemented | ||
| def set_balance(self, address: AddressType, amount: int): |
There was a problem hiding this comment.
Thank you for discussing this choice and future alternatives to making these test methods, like setting the balance or timestamp, only available on local/test chains.
…s/ape into feat/jules/set-bal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adds
set_balance()API toTestProviderAPIclass that raises not implemented by default.Hardhat and Foundry both use this!
How I did it
How to verify it
Checklist