Skip to content

Helmupdatefix #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anumita merged 4 commits into from
Feb 15, 2022
Merged

Helmupdatefix #5

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b7aadf
Use userValues.txt instead of --resuse-values in update command
sikasire Feb 11, 2022
e8297ad
fix error msg
sikasire Feb 11, 2022
02014ea
fix output file
sikasire Feb 15, 2022
55283c9
Merge branch 'customcert' of https://github.com/Anumita/azure-cli-ext…
sikasire Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/connectedk8s/azext_connectedk8s/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,17 +884,17 @@ def update_agents(cmd, client, resource_group_name, cluster_name, https_proxy=""
cmd_helm_values.extend(["--kubeconfig", kube_config])
if kube_context:
cmd_helm_values.extend(["--kube-context", kube_context])
cmd_helm_values.extend([">", "userValues.txt"])

response_helm_values_get = Popen(cmd_helm_values, stdout=PIPE, stderr=PIPE)

existing_user_values = open('userValues.txt', 'w+')
response_helm_values_get = Popen(cmd_helm_values, stdout=existing_user_values, stderr=PIPE)
_, error_helm_get_values = response_helm_values_get.communicate()
if response_helm_values_get.returncode != 0:
if ('forbidden' in error_helm_get_values.decode("ascii") or 'timed out waiting for the condition' in error_helm_get_values.decode("ascii")):
telemetry.set_user_fault()
telemetry.set_exception(exception=error_helm_get_values.decode("ascii"), fault_type=consts.Get_Helm_Values_Failed,
summary='Error while doing helm get values azure-arc')
raise CLIInternalError(str.format(consts.Update_Agent_Failure, error_helm_get_values.decode("ascii")))

cmd_helm_upgrade = [helm_client_location, "upgrade", "azure-arc", chart_path, "--namespace", release_namespace,
"-f",
"userValues.txt", "--wait", "--output", "json"]
Expand Down Expand Up @@ -926,8 +926,15 @@ def update_agents(cmd, client, resource_group_name, cluster_name, https_proxy=""
telemetry.set_user_fault()
telemetry.set_exception(exception=error_helm_upgrade.decode("ascii"), fault_type=consts.Install_HelmRelease_Fault_Type,
summary='Unable to install helm release')
try:
os.remove(existing_user_values.name)
except OSError:
pass
raise CLIInternalError(str.format(consts.Update_Agent_Failure, error_helm_upgrade.decode("ascii")))

try:
os.remove(existing_user_values.name)
except OSError:
pass
return str.format(consts.Update_Agent_Success, connected_cluster.name)


Expand Down