Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quad markers translation #9979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Quad markers translation #9979

wants to merge 1 commit into from

Conversation

Redstonneur1256
Copy link
Contributor

  • Adds default x, y, u and v positions to quad markers
  • Allows for quad markers to be translated using setmarker pos
  • Allow for quad marker vertices to be rotated around the center position using setmarker rotation
  • Adds @Transform for 2D matrices in the objectives dialog
  • Replacement for Relative quad marker vertices position #9738
  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

Anuken
Anuken reviewed Jul 7, 2024
View reviewed changes
core/src/mindustry/game/MapObjectives.java
@@ -1150,6 +1155,7 @@ public void draw(float scaleFactor){
if(fetchedRegion == null) setTexture(textureName);

Draw.z(drawLayer);
Draw.trans(transform);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Causing a batch flush every single quad draw call is not acceptable for performance. The vertices need to be manually transformed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anuken Anuken Anuken left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Redstonneur1256 @Anuken