-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to switch to planet by clicking on it from afar #9903
base: master
Are you sure you want to change the base?
Conversation
interesting |
Tested on Desktop and Android, maybe one would want to add a highlighter to the currently hovered planet but maybe it's actually just fine as-is |
I'm unsure about 3 things:
|
|
mindustry.mp4 |
mindustry2p.mp4 |
so the big issue I'm having is that I'm faced with a few choices:
|
this also fixes a segfault when selecting a planet without any sectors (this happens with some misconfigured mods) |
I'm not going to review this yet, but your style is wrong. Read the guidelines. |
thanks, I'll look over it. I though I kept most of it in mind but apparently I messed up. my bad |
ran the formatter over my changes and I hope it's serviceable now. The only style thing I'm sorta unsure about is the addition of |
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:
This sometimes bothered me when looking at the map.
Just let me click on a thing to get there instead of having to figure it out via menu.
Now I am happy.
I outlined the function
gotoPlanet
but I'm unsure if this was the correct thing to do styleguidewise.SCOPE EXPANDED: we're also doing smooth transitions now ig