-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play Sound Instruction for World Logic #9736
Open
Mythril382
wants to merge
37
commits into
Anuken:master
Choose a base branch
from
Mythril382:do-you-hear-the-voices-too
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythril382
changed the title
PlaySound Instruction for World Logic
Play Sound Instruction for World Logic
Apr 12, 2024
The commit names are so real |
Anuken
reviewed
Apr 24, 2024
anuke was right, this is a mess
Yes you should |
i can indeed confirm that this code(commit 0067af0) compiles and runs if using the arc pr as localArc |
build always fail guh |
Anuken
reviewed
Jun 20, 2024
Should mods be able to modify the volume limit? |
they never compile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how to implement loop sounds, so leave suggestions if possible.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: