[WIP] 1.17 fabric 3rd person render #398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyra314
reviewed
Oct 22, 2021
| @@ -67,6 +67,8 @@ private void drawMinimap(MatrixStack matrices, int atlasID, VertexConsumerProvid | |||
| matrices.push(); | |||
| matrices.translate(0, 0, 0.01); | |||
| Textures.BOOK.drawWithLight(buffer, matrices, 0, 0, (int) (GuiAtlas.WIDTH * 1.5), (int) (GuiAtlas.HEIGHT * 1.5), light); | |||
| // Book backside | |||
| Textures.BOOK.drawWithLightFlipped(buffer, matrices, 0, 0, (int) (GuiAtlas.WIDTH * 1.5), (int) (GuiAtlas.HEIGHT * 1.5), light); | |||
There was a problem hiding this comment.
I guess without NEA this should not be drawn, as nobody would see it anyways
There was a problem hiding this comment.
Yea in the current state this is missing these checks since I don't know the way you guys are planning to implement it. When there is no way to see the backside(so no NEA), this can be skipped of cause.
| } | ||
| if (arm != entity.getMainArm() && entity.getOffHandStack().getItem().equals(RegistrarAntiqueAtlas.ATLAS)) { // Only offhand | ||
| matrices.push(); | ||
| ((ModelWithArms) getContextModel()).setArmAngle(arm, matrices); |
There was a problem hiding this comment.
I have the very strong feeling, this code redundancy could be refactored away.
There was a problem hiding this comment.
That's true, its a bit of a copy and paste job that was different, but now could be refactored since these differences are not there any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this gets fully forgotten, this branch adds 3rd person rendering that works in combination with Not Enough Animations. Currently there are two options: disable this feature when NEA is not pressent, or copy over the arm translation mixins to make it work without NEA. Also the Atlas is currently missing its back texture.