Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping Seedfinding Library Version to fix SimOre outdating issue #376

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Bumping Seedfinding Library Version to fix SimOre outdating issue #376

merged 2 commits into from
Jan 25, 2025

Conversation

AzoteGwei
Copy link
Contributor

@AzoteGwei AzoteGwei commented Sep 2, 2024 •
edited
Loading

Description

Bump com.seedfinding:mc_core to 1.210.0

Related Issue

#143
#265
#296
#320
#326
#367

Same issue that reports that the OreSim has outdated.

Motivation and Context

Update com.seedfinding:mc_core to 1.210.0 can add support for 1.20.1-1.20.6,1.21

How Has This Been Tested?

Successfully builds artifacts.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • Have you successfully ran tests with your changes locally?

P.S.

Please remember to edit the com.seedfinding:mc_core version in build.gradle to make OreSim usable

@crazymoose7
Copy link
Contributor

Yes this is good to update the outdated aspect, but most of those issues relate to false positives with ore sim. Which is something not fixed by this change.

@AzoteGwei
Copy link
Contributor Author

Yes this is good to update the outdated aspect, but most of those issues relate to false positives with ore sim. Which is something not fixed by this change.

Most of issues I quoted was related to the .seed [seed] [version] command and utilities related to that would only support up to 1.20. Due to my decompiling result I found that the included version of seedfinding library matters in this process. The original commit was a wrapper of seedfinding so only bump the library version works.

Versions were defined in com.seedfinding.mccore.version.MCVersion and you could decompile the artifacts to verify this.

I’ve tested that on 1.21.1 it works operationally with the newest Meteor Dev version. And the SimOre works operationally either.

@crazymoose7
Copy link
Contributor

Definitely helpful! This should be merged, I think I was just mislead by some of the wording and inclusion of 143. But yes good fixes to those problems you mentioned.

Anyways I have started on the quest of fixing the false positives in the module, if you are interested in that too.

@RETROWSAV
Copy link

Yes this is good to update the outdated aspect, but most of those issues relate to false positives with ore sim. Which is something not fixed by this change.

Most of issues I quoted was related to the .seed [seed] [version] command and utilities related to that would only support up to 1.20. Due to my decompiling result I found that the included version of seedfinding library matters in this process. The original commit was a wrapper of seedfinding so only bump the library version works.

Versions were defined in com.seedfinding.mccore.version.MCVersion and you could decompile the artifacts to verify this.

I’ve tested that on 1.21.1 it works operationally with the newest Meteor Dev version. And the SimOre works operationally either.

Hi, can you tell me how to make oresim work for a 1.21 seed? what should i do specifically? thanks

@sbxte sbxte merged commit 4768fec into AntiCope:master Jan 25, 2025
1 check passed
sbxte added a commit that referenced this pull request Jan 30, 2025
@dependabot @Xtendera
@crazymoose7 @sbxte @AzoteGwei
github-actions(deps): bump actions/upload-artifact from 3 to 4 (#408)
1783149 
[no ci]

* Update to 1.21.3/1.21.4 (#399)

* Update to 1.21.3 part 1

Don't expect it to work anytime soon.

* Update to 1.21.3 part 2

* Gradle 8.8 -> 8.12

* Working Build 1.21.3

Had to revert gradle to 8.10 due to unforseen issues.

* Removed Unused Imports

* Small rendering fixes (hopefully)

* 1.21.4 port

* Use Utils.canUpdate in AutoCraft

* Intellij code fixes

---------

Co-authored-by: crazymoose77756 <[email protected]>
Co-authored-by: SByte <[email protected]>

* github-actions(deps): bump actions/checkout from 3 to 4 (#288)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: SByte <[email protected]>

* github-actions(deps): bump actions/setup-java from 3.10.0 to 3.13.0 (#289)

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.10.0 to 3.13.0.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v3.10.0...v3.13.0)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: SByte <[email protected]>

* Bumping Seedfinding Library Version to fix SimOre outdating issue (#376)

* Update build.gradle for seedfinding lib

---------

Co-authored-by: SByte <[email protected]>

* Update version displayed on build workflow

* github-actions(deps): bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Ashray Shah <[email protected]>
Co-authored-by: crazymoose77756 <[email protected]>
Co-authored-by: SByte <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Azote | 窒垝 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AzoteGwei @crazymoose7 @RETROWSAV @sbxte