Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: my-slider-v2 allowTapping false not working #49

Closed
L-E-0-N opened this issue Jun 15, 2023 · 6 comments
Closed

[Bug]: my-slider-v2 allowTapping false not working #49

L-E-0-N opened this issue Jun 15, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@L-E-0-N
Copy link

L-E-0-N commented Jun 15, 2023

Current Behavior

When setting the value 'allowTapping' to 'false' it's won't function at all. Neither by tapping (makes sense) but also not by dragging the thumb which is wanted. There is no way to adjust the slider.

Expected Behavior

To only be able to change the value by dragging the thumb.

Steps To Reproduce

  1. Create a new my-slider-v2 card
  2. Use some basic version:
entity: light.tafellamp_groep
allowTapping: false
styles:
  card:
    - height: 50px
  1. Try changing the value by dragging the thumb, it's not working

Environment

- OS: Intel Nuc Generic x86-64
- Browser: MacOS Chrome / Home Assistant iOS companion app
- Version: Mybundle v1.0.2
- Hassio: 2023.6.2

Anything else?

No response

@L-E-0-N L-E-0-N added the bug Something isn't working label Jun 15, 2023
@AnthonMS
Copy link
Owner

AnthonMS commented Jun 18, 2023

No I have experienced this lately as well. I will try to take a look at it soon hopefully.

@AnthonMS AnthonMS self-assigned this Jun 18, 2023
@L-E-0-N
Copy link
Author

L-E-0-N commented Jun 22, 2023

No I have experienced this lately as well. I will try to take a look at it soon hopefully.

That would be awesome!

@DANIELlOlL
Copy link

I also experienced this problem, cause i wanted to turn off Tapping, so that I can scroll trough my Dashboard without turning any lights on or off. Did you find a solution for this Problem?

AnthonMS added a commit that referenced this issue Feb 1, 2024
#49 allowTapping false not working has been fixed. And a new config key has been added 'marginOfError'. It is 10 default. marginOfError is amount of pixels the input can be from the thumb.
#27 No step option has been fixed. There has always been a step option, just very broken logic. It has been fixed and the slider will now only update to closest step.
@AnthonMS
Copy link
Owner

AnthonMS commented Feb 1, 2024

This should be fixed in the latest release. Let me know if there are more issues.

@AnthonMS AnthonMS closed this as completed Feb 1, 2024
@DANIELlOlL
Copy link

Yes :) it works thanks

@L-E-0-N
Copy link
Author

L-E-0-N commented Feb 21, 2024

This should be fixed in the latest release. Let me know if there are more issues.

This is great! But to challenge it one step further. Now it’s still not possible to scroll when placing a finger on the slider and dragging vertical. Meaning when your dashboard has multiple slider, we still need to carefully place our finger to scroll up and down the dashboard. Ortherwise we’re scrolling within a slider and its not working. Do you think there could be a fix for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants