IF: Do not set new proposer policy unless different #68
Conversation
libraries/chain/controller.cpp
Outdated
| if (auto itr = parent.proposer_policies.find(active_time); itr != parent.proposer_policies.cend()) { | ||
| return itr->second->proposer_schedule.version; // will replace so return same version | ||
| // returns the next proposer schedule version and true if different | ||
| // if producers is not different then returns the current schedule version (or next schedule version) |
There was a problem hiding this comment.
Remove the leading spaces.
|
|
||
| const producer_authority_schedule& lhs = get_next_sched(); | ||
|
|
||
| if (std::ranges::equal(lhs.producers, producers)) { |
There was a problem hiding this comment.
Just curious, any reason why you use std::ranges::equal() instead of operator==() on the vectors?
There was a problem hiding this comment.
Only because that is what legacy does. Should be the same.
|
Hum, I kept looking at it some more and I don't think it behaves as the previous code did. and we don't remove any existing proposed_schedule set earlier in this block (with So am I correct that we have not removed the one set earlier in the block, and should have been superseded by the new one which is identical to the previously active one? |
|
Note:start |
Resolves #6