Skip to content

Finality violation tests #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 58 commits into from
Closed

Finality violation tests #501

wants to merge 58 commits into from

Conversation

@systemzax
Copy link
Member

@systemzax systemzax commented Aug 8, 2024

This PR adds tests to cover violation of finality rule #1, #2 and #3 and addresses issue : #91

systemzax added 30 commits July 29, 2024 06:18
@systemzax
Added placeholder svnn_finality_violation.cpp and updated cmake files
686986e
@systemzax
Added placeholder finality_violation smart contract
b345e76
@systemzax
Converted proof_test_cluster to use fixed size nodes, added vote_prop…
920d7aa 
…agation flags
@systemzax
Added vote propagation tests
0f83dea
@systemzax
Initial set up for finality violation tests
2eff199
@systemzax
Progress on initial tests
38ccb3b
@systemzax
Comments related to rule #1 violation
cbcbc27
@systemzax
Updated ibc_block_data_t structure to expose all level 2 and level 3 …
a686f00 
…commitments
@systemzax
Updated savanna contract common code to support level 3 commitments
a82435a
@systemzax
Added rule #1 finality violation action to smart contract, tests
e295f9d
@systemzax
Remove commented out code
bca8c83
@systemzax
Removed unused parameter in svnn_ibc_tests
84f6c08
@systemzax
Changed pending_finalizer_policy to last_pending_finalizer_policy in …
3fc7806 
…savanna contract for clarity
@systemzax
Updated finality violation tests to reflect new name
5a26775
@systemzax
Renamed last_pending_finalizer_policy_generation to pending_finalizer…
90f5f45 
…_policy_generation in savanna smart contracts and tests for clarity
@systemzax
Removed temporary checkpoints from svnn_ibc_tests
e7d3263
@systemzax
Small refactor of finality violation tests
9e90bbf
@systemzax
Prepared test for rule #2
484c229
@systemzax
Implemented rule #2 verification in savanna contracts, improved proof
4da02e7 
generation used in finality violation tests
@systemzax
Added savanna contract interface for weak QCs
5acaae2
@systemzax
Completed savanna contract support for weak QCs
7ea485e
@systemzax
Reordered proof generation to ensure only the most recent information…
1be2257 
… collected by the light client is used
@systemzax
WIP
891207d
@systemzax
Replaced policy digests and generations returned by process_result fu…
19d1b5d 
…nction with full policies
@systemzax
Modified tests to use light client data cache only
2f5a557
@systemzax
Removed leftover comments
67440e4
@systemzax
Minor code reorganization plus added comments for clarity
3559929
@systemzax
Fixed incorrect assignement in savanna contract, recompiled contract
ec68dd5
@systemzax
Corrected order and names of sub rules
0ff0c8d
@systemzax
Desambiguated rule2 (now rule2a and rule2b) to differentiate between …
a99e673 
…scenarios where the fake block's timestamp is lower vs higher than block with conflicting range
systemzax added 13 commits August 7, 2024 12:02
@systemzax
Completed rule 2
6ea3f25
@systemzax
Clean up
ac03de3
@systemzax
Renamed minimal_block_data to finality_block_data
c5bdd90
@systemzax
Adjusted order of events to more closely reflect the light client beh…
09b612f 
…avior
@systemzax
Obtain reference to fake chain blocks via the list of reversible bloc…
724b942 
…ks stored by light client for better encapsulation
@systemzax
Added rule #3 to smart contract
39b8665
@systemzax
Added proof of rule #3 finality violation test
1c6e055
@systemzax
Added comments to smart contract, recompiled
a61fd4c
@systemzax
Fixed a few bugs, added additional rule #3 test where fake chain is a…
c7120c9 
…head of real chain
@systemzax
Updated finality violation contract actions to return guilty vs innoc…
506c33b 
…ent finalizers upon successful proof verifcation
@systemzax
Added bitset tests to ibc tests to cover the exact blame and exonerat…
2951cc1 
…ion of finalizers in finality violation tests
@systemzax
Removed unused return statements, added comments about bitset verific…
4462524 
…ation
@systemzax
Merge branch 'main' into finality_violation_tests
2117c6f
@systemzax systemzax marked this pull request as ready for review August 8, 2024 14:50
@ericpassmore
Copy link
Contributor

ericpassmore commented Aug 8, 2024

Note:start
group: STABILITY
category: TEST
summary: Tests to cover violation of finality rule.
Note:end

@arhag arhag linked an issue Aug 12, 2024 that may be closed by this pull request
Finality violation test coverage #91
Open
@arhag
Copy link
Member

arhag commented Aug 20, 2024 •
edited
Loading

This should target release/1.0. But don't just retarget this PR to release/1.0 since that would bring main commits into the release branch. Instead, close this PR and create a new one that is built off of release/1.0. Also, there should be no change to the chainbase submodule within that new PR.

@systemzax
Copy link
Member Author

systemzax commented Aug 21, 2024

Closing. New PR is here : #610

@systemzax systemzax closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Finality violation test coverage

4 participants

@systemzax @ericpassmore @arhag