Skip to content

Conversation

@heifner
Copy link
Contributor

@heifner heifner commented Apr 15, 2024

Various renaming to remove references to hotstuff nomenclature.

Resolves #12

@heifner heifner added the OCI Work exclusive to OCI team label Apr 15, 2024
@heifner heifner linked an issue Apr 15, 2024 that may be closed by this pull request
@heifner heifner requested review from greg7mdp and linh2931 April 15, 2024 17:19
Copy link
Contributor

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need finality directory? Can everything under original hotstuff be moved to chain?

@heifner
Copy link
Contributor Author

heifner commented Apr 15, 2024

Do we still need finality directory? Can everything under original hotstuff be moved to chain?

They could be, but seems nice to keep it seperated.

@linh2931
Copy link
Contributor

Do we still need finality directory? Can everything under original hotstuff be moved to chain?

They could be, but seems nice to keep it seperated.

OK. It's just a style.

@greg7mdp
Copy link
Contributor

If we are going to keep the finality directories, probably we should move finality_core to them.

Base automatically changed from GH-14-vote-loggin to savanna April 19, 2024 13:29
@heifner heifner merged commit 64b77f4 into savanna Apr 19, 2024
@heifner heifner deleted the GH-12-cleanup branch April 19, 2024 14:40
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Make code more readable, by removing hotstuff nomenclature.
Note:end

greg7mdp added a commit that referenced this pull request Apr 25, 2025
Add dynamic check for pagemap support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCI Work exclusive to OCI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up hotstuff directory after unification

5 participants