validate LLVM & cmake tarball hashes in reproducible build #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Aug 25, 2025
| 0b58557a6d32ceee97c8d533a59b9212d87e0fc4d2833924eb6c611247db2f2a llvm-project-${_SPRING_CLANG_VERSION}.src.tar.xz | ||
| 74d2529159fd118c3eac6f90107b5611bccc6f647fdea104024183e8d5e25831 llvm-project-${_SPRING_LLVM_VERSION}.src.tar.xz | ||
| ef3056df528569e0e8956f6cf38806879347ac6de6a4ff7e4105dc4578732cfb cmake-${_SPRING_CMAKE_VERSION}.tar.gz | ||
| EOF |
There was a problem hiding this comment.
btw Dockerfile's ADD has the ability to --checksum, but you can't ADD multiple files when using --checksum. So I kinda like this approach here over splitting up in to multiple ADD commands, since I like how the existing ADD command groups the tarball and signature together.
|
ah this is busted until #1843 goes in, I should have chained it off that branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we already validate the GPG signatures on LLVM & cmake in our reproducible build, but similar to reasoning of #1841 maybe we'd like to validate the exact hashes as well to prevent some attack vectors.